Re: [PATCH] grep: Add option --max-line-len

2017-11-26 Thread Junio C Hamano
Marc-Antoine Ruel writes: > [second try, now with text format] > > Thanks a lot for the reviews. Replying to both. > > If I send a follow up, I'll fix the commit description and the help > string, remove the shorthand -M, write a more sensible test. > > ... > > Thanks for

Re: [PATCH] grep: Add option --max-line-len

2017-11-26 Thread Marc-Antoine Ruel
[second try, now with text format] Thanks a lot for the reviews. Replying to both. If I send a follow up, I'll fix the commit description and the help string, remove the shorthand -M, write a more sensible test. 2017-11-23 14:24 GMT-05:00 Eric Sunshine : >> diff --git

Re: [PATCH] grep: Add option --max-line-len

2017-11-23 Thread Junio C Hamano
Marc-Antoine Ruel writes: > This tells git grep to skip files longer than a specified length, > which is often the result of generators and not actual source files. > > ... > +-M:: > +--max-line-len:: > + Match the pattern only for line shorter or equal to this length. >

Re: [PATCH] grep: Add option --max-line-len

2017-11-23 Thread Eric Sunshine
On Thu, Nov 23, 2017 at 10:41 AM, Marc-Antoine Ruel wrote: > This tells git grep to skip files longer than a specified length, s/files/lines/ > which is often the result of generators and not actual source files. > > Signed-off-by: Marc-Antoine Ruel >