Re: [PATCH] pull: respect submodule update configuration

2017-08-22 Thread Brandon Williams
On 08/22, Stefan Beller wrote: > On Tue, Aug 22, 2017 at 7:50 AM, Lars Schneider > wrote: > > > > OK. I change my scripts to use ".active" and it seems to work nicely. > > > > I noticed one oddity, though: > > > > If I clone a repo using `git clone --recursive ` then the

Re: [PATCH] pull: respect submodule update configuration

2017-08-22 Thread Stefan Beller
On Tue, Aug 22, 2017 at 7:50 AM, Lars Schneider wrote: > > OK. I change my scripts to use ".active" and it seems to work nicely. > > I noticed one oddity, though: > > If I clone a repo using `git clone --recursive ` then the local > Git config of the repo gets the

Re: [PATCH] pull: respect submodule update configuration

2017-08-22 Thread Lars Schneider
> On 21 Aug 2017, at 20:21, Brandon Williams wrote: > > On 08/21, Stefan Beller wrote: >> On Mon, Aug 21, 2017 at 10:20 AM, Lars Schneider >> wrote: >>> On 21 Aug 2017, at 18:55, Stefan Beller wrote: On Mon, Aug

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Junio C Hamano
Brandon Williams writes: >> > I tried to make it work here: >> > https://public-inbox.org/git/89ab8aa3-8e19-46ba-b169-d1ea4cf4a...@gmail.com/ >> >> (A) you need to set expect there as well, to have sub{2,4,5} be expected >> there as well. >> >> (B) That may hint at another

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Brandon Williams
On 08/21, Stefan Beller wrote: > On Mon, Aug 21, 2017 at 10:20 AM, Lars Schneider > wrote: > > > >> On 21 Aug 2017, at 18:55, Stefan Beller wrote: > >> > >> On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: > >> > So I am a

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Stefan Beller
On Mon, Aug 21, 2017 at 10:20 AM, Lars Schneider wrote: > >> On 21 Aug 2017, at 18:55, Stefan Beller wrote: >> >> On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: >> So I am a bit curious to learn which part of this change

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Lars Schneider
> On 21 Aug 2017, at 18:55, Stefan Beller wrote: > > On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: > >>> So I am a bit curious to learn which part of this change you dislike >>> and why. >> >> I am also curious. Isn't this the same strategy we are

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Stefan Beller
On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: >> So I am a bit curious to learn which part of this change you dislike >> and why. > > I am also curious. Isn't this the same strategy we are using in other > places? > I dislike it because the UX feels crude. When reading

Re: [PATCH] pull: respect submodule update configuration

2017-08-21 Thread Heiko Voigt
On Fri, Aug 18, 2017 at 11:24:47PM -0700, Junio C Hamano wrote: > Stefan Beller writes: > > > From: Lars Schneider > > > > Do not override the submodule configuration in the call to update > > the submodules, but give a weaker default. > > > >

Re: [PATCH] pull: respect submodule update configuration

2017-08-19 Thread Junio C Hamano
Stefan Beller writes: > From: Lars Schneider > > Do not override the submodule configuration in the call to update > the submodules, but give a weaker default. > > Reported-by: Lars Schneider > Signed-off-by: Stefan Beller

Re: [PATCH] pull: respect submodule update configuration

2017-08-19 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Aug 18, 2017 at 3:04 PM, Stefan Beller wrote: >> From: Lars Schneider > > eh, that is what I get for amending to Lars patch. Sorry, I do not understand this remark. If you started from a patch

Re: [PATCH] pull: respect submodule update configuration

2017-08-18 Thread Stefan Beller
On Fri, Aug 18, 2017 at 3:04 PM, Stefan Beller wrote: > From: Lars Schneider eh, that is what I get for amending to Lars patch.