Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Eric Sunshine
On Mar 12, 2014, at 2:38 AM, Orgad Shaneh org...@gmail.com wrote: Executes checkout without -q — Missing sign-off. See Documentation/SubmittingPatches. Your patch is badly whitespace-damaged, as if it was pasted into your email client. “git send-email” can avoid this problem. As I’m not a

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Jens Lehmann
Am 12.03.2014 14:42, schrieb Orgad Shaneh: From: Orgad Shaneh org...@gmail.com You don't need the line above when you are the sender ;-) Executes checkout without -q That's a bit terse. What about: Add the verbose flag to add and update which displays the progress of the actual submodule

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Orgad Shaneh
On Wed, Mar 12, 2014 at 6:15 PM, Jens Lehmann jens.lehm...@web.de wrote: Am 12.03.2014 14:42, schrieb Orgad Shaneh: From: Orgad Shaneh org...@gmail.com You don't need the line above when you are the sender ;-) Executes checkout without -q That's a bit terse. What about: Add the

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Junio C Hamano
Orgad Shaneh org...@gmail.com writes: +--verbose:: + This option is valid for add and update commands. Display the progress + of the actual submodule checkout. Hmm, is the valid for add and update part we want to keep? I do not think it is a crime if some other subcommand accepted

Re: [PATCH] submodule: add verbose mode for add/update

2013-04-10 Thread Jens Lehmann
Am 10.04.2013 20:24, schrieb Orgad Shaneh: Executes checkout without -q Nice, looks like you picked the proposal I made last September: http://permalink.gmane.org/gmane.comp.version-control.git/204747 The change is looking good, but you still need to document the new option in