Re: [PATCH] xdiff: rename "struct group" to "struct xdlgroup"

2016-09-27 Thread Jeff King
On Tue, Sep 27, 2016 at 03:18:02PM +0200, Michael Haggerty wrote: > > Let's resolve by giving the xdiff variant a scoped name, > > which is closer to other xdiff types anyway (e.g., > > xdlfile_t, though note that xdiff is fond if typedefs when > > Git usually is not). > > Makes sense to me. I

Re: [PATCH] xdiff: rename "struct group" to "struct xdlgroup"

2016-09-27 Thread Stefan Beller
On Mon, Sep 26, 2016 at 9:37 PM, Jeff King wrote: > Commit e8adf23 (xdl_change_compact(): introduce the concept > of a change group, 2016-08-22) added a "struct group" type > to xdiff/xdiffi.c. But the POSIX system header "grp.h" > already defines "struct group" (it is part of the

Re: [PATCH] xdiff: rename "struct group" to "struct xdlgroup"

2016-09-27 Thread Michael Haggerty
On 09/27/2016 06:37 AM, Jeff King wrote: > Commit e8adf23 (xdl_change_compact(): introduce the concept > of a change group, 2016-08-22) added a "struct group" type > to xdiff/xdiffi.c. But the POSIX system header "grp.h" > already defines "struct group" (it is part of the getgrnam > interface).