Re: [PATCH 02/15] read-cache: Improve readability

2015-03-22 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: Maybe I have read too much of the refs code lately as there we have these long chains which combine precondition with error checking. Of course, things are not so black-and-white in the real world. You can also take an extreme stance and view

Re: [PATCH 02/15] read-cache: Improve readability

2015-03-20 Thread Stefan Beller
On Fri, Mar 20, 2015 at 9:19 PM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: Signed-off-by: Stefan Beller sbel...@google.com --- read-cache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/read-cache.c b/read-cache.c index

Re: [PATCH 02/15] read-cache: Improve readability

2015-03-20 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: Signed-off-by: Stefan Beller sbel...@google.com --- read-cache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/read-cache.c b/read-cache.c index f72ea9f..769897e 100644 --- a/read-cache.c +++ b/read-cache.c @@ -703,9