Re: [PATCH 08/12] t5520: use test_cmp_rev where possible

On Fri, Oct 18, 2019 at 2:52 PM Denton Liu wrote: > On Thu, Oct 17, 2019 at 07:41:44PM -0400, Eric Sunshine wrote: > > On Thu, Oct 17, 2019 at 7:17 PM Denton Liu wrote: > > > - test "$COPY" = "$(git rev-parse --verify me/copy)" && > > > + test_cmp_rev "$COPY" me/copy && > > > > This t

Re: [PATCH 08/12] t5520: use test_cmp_rev where possible

Hi Eric, Thanks for the reviews. I have no idea how you always get to my patches so quickly but I appreciate the prompt reviews whenever I send a test-related patchset in. I've fixed up the other concerns you had and I'll send a v2 later but I wanted to address this one. On Thu, Oct 17, 2019 at

Re: [PATCH 08/12] t5520: use test_cmp_rev where possible

On Thu, Oct 17, 2019 at 7:17 PM Denton Liu wrote: > In case an invocation of `git rev-list` fails within the subshell, the > failure will be masked. Remove the subshell and use test_cmp_rev() so > that failures can be discovered. > > Signed-off-by: Denton Liu > --- > diff --git a/t/t5520-pull.sh