Re: [PATCH 1/4] line-log: demonstrate a bug with nearly-overlapping ranges

2018-08-06 Thread Jonathan Nieder
Jonathan Nieder wrote: > Johannes Schindelin wrote: >> It is really, really important to realize how valuable it is to have the >> regression test as an individual patch that can be used to verify that >> there is a bug, to pinpoint where it was introduced, to test alternative >> fixes, to keep

Re: [PATCH 1/4] line-log: demonstrate a bug with nearly-overlapping ranges

2018-08-06 Thread Jonathan Nieder
Hi Dscho, Johannes Schindelin wrote: > On Sat, 4 Aug 2018, Jonathan Nieder wrote: >> Alternatively, could it be squashed in with the patch that fixes it? > > There is this really awful trend on this mailing list to suggest > conflating the demonstration of a bug with the bug fix. > > It is

Re: [PATCH 1/4] line-log: demonstrate a bug with nearly-overlapping ranges

2018-08-06 Thread Johannes Schindelin
Hi Jonathan, On Sat, 4 Aug 2018, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > > Currently, this test case throws an assertion: > > > > Assertion failed! > > > > Program: git.exe > > File: line-log.c, Line 71 > > > > Signed-off-by: Johannes Schindelin > > --- > >

Re: [PATCH 1/4] line-log: demonstrate a bug with nearly-overlapping ranges

2018-08-04 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > Currently, this test case throws an assertion: > > Assertion failed! > > Program: git.exe > File: line-log.c, Line 71 > > Signed-off-by: Johannes Schindelin > --- > t/t4211-line-log.sh | 17 + > 1 file changed, 17 insertions(+)