Re: [PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function

2018-11-01 Thread Junio C Hamano
Junio C Hamano writes: > As we currently have no idea when builtin/stash.c becomes ready for > 'next', how about doing something like this instead, in order to > help end-users without waiting in the meantime? The fix can be > picked up and ported when the C rewrite is updated, of course. I

Re: [PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function

2018-11-01 Thread Junio C Hamano
Junio C Hamano writes: > Rather than adding this fallback trap, can't we do it more like > this? > > - At the beginning of "git stash", after parsing the command > line, we know what subcommand of "git stash" we are going to > run. > > - If it is a subcommand that could need

Re: [PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function

2018-11-01 Thread Junio C Hamano
Slavica Djukic writes: > Usually, when creating a commit, ident is needed to record the author > and commiter. > But, when there is commit not intended to published, e.g. when stashing > changes, valid ident is not necessary. > To allow creating commits in such scenario, let's introduce helper