On Fri, Dec 11, 2015 at 6:44 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>>> As you know I am bad at bikeshedding; the only suggestion in the
>>> above is to have common UC_ prefix ;-) Don't take what follow UC_
>>> as my suggestion.
>>
On Thu, Dec 10, 2015 at 7:46 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
+/* Untracked cache mode */
+enum uc_mode {
+ UNDEF_UC = -1,
+ NO_UC = 0,
+ UC,
+ FORCE_UC
+};
+
>>>
>>> With
Christian Couder writes:
>> As you know I am bad at bikeshedding; the only suggestion in the
>> above is to have common UC_ prefix ;-) Don't take what follow UC_
>> as my suggestion.
>
> I am bad at finding names too, so I think what you wrote is pretty good.
>
> I
On Tue, Dec 8, 2015 at 8:11 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> Signed-off-by: Christian Couder
>> ---
>> builtin/update-index.c | 18 +-
>> 1 file changed, 13 insertions(+), 5
Christian Couder writes:
>>> +/* Untracked cache mode */
>>> +enum uc_mode {
>>> + UNDEF_UC = -1,
>>> + NO_UC = 0,
>>> + UC,
>>> + FORCE_UC
>>> +};
>>> +
>>
>> With these, the code is much easier to read than with the mystery
>> constants, but did you
Christian Couder writes:
> Signed-off-by: Christian Couder
> ---
> builtin/update-index.c | 18 +-
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index
6 matches
Mail list logo