Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

On 12/13, Lars Schneider wrote: > > > On 13 Dec 2017, at 18:38, Junio C Hamano wrote: > > > > Lars Schneider writes: > > > >> I think your solution points into the right direction. > >> Right now we have the following test matrix: > >> > >> 1.

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

On 12/12, Junio C Hamano wrote: > Thomas Gummerer writes: > > > > > The breakages wen the split-index code fails tend to break things in > > much more obvious manners than a wrong message, usually git ends up > > dying if it gets broken. Both of the bugs that were fixed

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

> On 13 Dec 2017, at 18:38, Junio C Hamano wrote: > > Lars Schneider writes: > >> I think your solution points into the right direction. >> Right now we have the following test matrix: >> >> 1. Linux - clang >> 2. Linux - gcc >> 3. Mac - clang >>

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

Lars Schneider writes: > I think your solution points into the right direction. > Right now we have the following test matrix: > > 1. Linux - clang > 2. Linux - gcc > 3. Mac - clang > 4. Mac - gcc > 5. Linux - gcc - GET_TEXT_POISION > 6. Linux - gcc - 32bit > 7. Windows

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

> On 12 Dec 2017, at 20:15, Junio C Hamano wrote: > > Lars Schneider writes: > >>> You're right, it's my first time using travis CI and I got confused >>> about how the .travis.yml works, thanks for catching that. Will >>> re-phrase the commit

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

Thomas Gummerer writes: > > The breakages wen the split-index code fails tend to break things in > much more obvious manners than a wrong message, usually git ends up > dying if it gets broken. Both of the bugs that were fixed here would > have been caught with the change

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

On 12/12, Junio C Hamano wrote: > Lars Schneider writes: > > >> You're right, it's my first time using travis CI and I got confused > >> about how the .travis.yml works, thanks for catching that. Will > >> re-phrase the commit message. > > > > Szeder is spot on. If you

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

Lars Schneider writes: >> You're right, it's my first time using travis CI and I got confused >> about how the .travis.yml works, thanks for catching that. Will >> re-phrase the commit message. > > Szeder is spot on. If you fix up the message, then this patch looks >

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

> On 11 Dec 2017, at 22:42, Thomas Gummerer wrote: > > On 12/11, SZEDER Gábor wrote: >>> Make sure that split index doesn't get broken, by running it on travis >>> CI. >>> >>> Run the test suite with split index enabled in linux 64 bit mode, and >>> leave split index

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

On 12/11, SZEDER Gábor wrote: > > Make sure that split index doesn't get broken, by running it on travis > > CI. > > > > Run the test suite with split index enabled in linux 64 bit mode, and > > leave split index turned off in 32-bit mode. > > This doesn't accurately describe what the patch

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

> Make sure that split index doesn't get broken, by running it on travis > CI. > > Run the test suite with split index enabled in linux 64 bit mode, and > leave split index turned off in 32-bit mode. This doesn't accurately describe what the patch does. Travis CI runs three 64 bit Linux build

Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

On Sun, Dec 10, 2017 at 4:22 PM, Thomas Gummerer wrote: > Make sure that split index doesn't get broken, by running it on travis > CI. > > Run the test suite with split index enabled in linux 64 bit mode, and > leave split index turned off in 32-bit mode. The laternative