Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: > Exactly, sorry for not writing my chain of thoughts down completely. > > To make them reusable, I'd assume we want them to be easy to > understand, and by using a well known way in git it is easier to > understand. I already said I do not care too

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Fri, Mar 25, 2016 at 10:25 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> The way all the subcommand written in C works is >> >> - The start-up sequence does the repository discovery, which >>involves crawling up to the top-level of the

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Junio C Hamano writes: > The way all the subcommand written in C works is > > - The start-up sequence does the repository discovery, which >involves crawling up to the top-level of the working tree, and >compute "prefix", where the end-user was when the command was >

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Fri, Mar 25, 2016 at 10:01 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> The other reason you gave below is also convincing: By having it in the >> prefix, >> the C code is more likely correct and future proof. >> >> On rewriting the whole

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: > The other reason you gave below is also convincing: By having it in the > prefix, > the C code is more likely correct and future proof. > > On rewriting the whole submodule command in C (probably > reiterating): It is not my endgoal to rewrite every

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Thu, Mar 24, 2016 at 11:28 PM, Junio C Hamano wrote: > > So this change may not be wrong per-se, but if the lossage of prefix > is the final goal (as opposed to an approach to gain other benefits, > e.g. "now we do not have to use prefix, we can simplify these other >

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> The usual early machinery of Git is to change the directory to >> the top level of the working tree and pass the actual path inside >> the working tree as `prefix` to the command being run. >> >> This is

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: > The usual early machinery of Git is to change the directory to > the top level of the working tree and pass the actual path inside > the working tree as `prefix` to the command being run. > > This is the case both for commands written in C (where the >

Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

2016-03-24 Thread Jacob Keller
On Thu, Mar 24, 2016 at 4:34 PM, Stefan Beller wrote: > The usual early machinery of Git is to change the directory to > the top level of the working tree and pass the actual path inside > the working tree as `prefix` to the command being run. > This is the case both for