Re: [PATCH 3/5] Makefile: add helper for compiling with -fsanitize

2017-07-10 Thread Jeff King
On Mon, Jul 10, 2017 at 09:02:24PM +0100, Ramsay Jones wrote: > After a quick look at the ./t-basic.sh test, I managed to get > the test to complete (with 15 tests failing), with the following > patch applied: > > -- >8 -- > diff --git a/Makefile b/Makefile > index 3c341b2a6..8e6433738

Re: [PATCH 3/5] Makefile: add helper for compiling with -fsanitize

2017-07-10 Thread Ramsay Jones
On 10/07/17 18:44, Jeff King wrote: > On Mon, Jul 10, 2017 at 10:35:24AM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >>> You can already build and test with ASan by doing: >>> >>> make CFLAGS=-fsanitize=address test >>> >>> but there are a few slight annoyances: >>>

Re: [PATCH 3/5] Makefile: add helper for compiling with -fsanitize

2017-07-10 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 10, 2017 at 10:35:24AM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > You can already build and test with ASan by doing: >> > >> > make CFLAGS=-fsanitize=address test >> > >> > but there are a few slight annoyances:

Re: [PATCH 3/5] Makefile: add helper for compiling with -fsanitize

2017-07-10 Thread Jeff King
On Mon, Jul 10, 2017 at 10:35:24AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > You can already build and test with ASan by doing: > > > > make CFLAGS=-fsanitize=address test > > > > but there are a few slight annoyances: > > > > 1. It's a little long to type. > > >

Re: [PATCH 3/5] Makefile: add helper for compiling with -fsanitize

2017-07-10 Thread Junio C Hamano
Jeff King writes: > You can already build and test with ASan by doing: > > make CFLAGS=-fsanitize=address test > > but there are a few slight annoyances: > > 1. It's a little long to type. > > 2. It override your CFLAGS completely. You'd probably > still want -O2, for