Re: [PATCH 5/5] tests: explicitly use `git.exe` on Windows

2018-11-14 Thread Junio C Hamano
Johannes Schindelin writes: >> The latter half of this change is a good one. Given what the >> proposed log message of this patch says >> >> Note also: the many, many calls to `git this` and `git that` are >> unaffected, as the regular PATH search will find the `.exe` files on >>

Re: [PATCH 5/5] tests: explicitly use `git.exe` on Windows

2018-11-14 Thread Johannes Schindelin
Hi Junio, On Wed, 14 Nov 2018, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > diff --git a/Makefile b/Makefile > > index bbfbb4292d..5df0118ce9 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -2590,6 +2590,7 @@ GIT-BUILD-OPTIONS: FORCE > > @echo

Re: [PATCH 5/5] tests: explicitly use `git.exe` on Windows

2018-11-13 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > diff --git a/Makefile b/Makefile > index bbfbb4292d..5df0118ce9 100644 > --- a/Makefile > +++ b/Makefile > @@ -2590,6 +2590,7 @@ GIT-BUILD-OPTIONS: FORCE > @echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst > ','\'',$(NO_UNIX_SOCKETS)))'\'