Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

2015-08-17 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: --- Does the lack of sign-off indicate something (like this is just a 'what do people think?' weatherbaloon not yet a serious submission)? +push.gpgSign:: + May be set to a boolean value, or the string 'if-possible'. A + true value causes

Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

2015-08-17 Thread Dave Borowitz
On Mon, Aug 17, 2015 at 1:13 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: --- Does the lack of sign-off indicate something (like this is just a 'what do people think?' weatherbaloon not yet a serious submission)? +push.gpgSign:: + May be set

Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

2015-08-17 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: The issue is that if both _ALWAYS and _IF_POSSIBLE are set, git_transport_push interprets it as _ALWAYS. But, we are also supposed to prefer explicit command-line options to config values. Suppose we parsed config first, then options. If the user

Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

2015-08-17 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Dave Borowitz dborow...@google.com writes: The issue is that if both _ALWAYS and _IF_POSSIBLE are set, git_transport_push interprets it as _ALWAYS. But, we are also supposed to prefer explicit command-line options to config values. Suppose we parsed

Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

2015-08-17 Thread Dave Borowitz
On Mon, Aug 17, 2015 at 3:42 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: The issue is that if both _ALWAYS and _IF_POSSIBLE are set, git_transport_push interprets it as _ALWAYS. But, we are also supposed to prefer explicit command-line options to