Re: [PATCH 8/9] branch: use ref-filter printing APIs

Karthik Nayak writes: > On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy > wrote: > >> To go a bit further, you can pre-build a string or strbuf aligned_short >> with value like "%%(align:20,left)%%(refname:short)%%(end)" and use it >> where

Re: [PATCH 8/9] branch: use ref-filter printing APIs

On Wed, Oct 7, 2015 at 11:28 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy >> wrote: >> >>> To go a bit further, you can pre-build a string or strbuf

Re: [PATCH 8/9] branch: use ref-filter printing APIs

On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy wrote: > Karthik Nayak writes: > >> If you look closely, thats only for the local branches, the remotes >> have `align` atom when >> printing in verbose. > > Yes, but that's already one thing

Re: [PATCH 8/9] branch: use ref-filter printing APIs

On Tue, Oct 6, 2015 at 12:13 AM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Sat, Oct 3, 2015 at 6:11 PM, Matthieu Moy >> wrote: >>> Actually, this is not a performance-cricical piece of code at all, so I

Re: [PATCH 8/9] branch: use ref-filter printing APIs

On Sat, Oct 3, 2015 at 6:11 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> - if (upstream_is_gone) { >> - if (show_upstream_ref) >> - strbuf_addf(stat, _("[%s: gone]"), fancy.buf); > > The old string

Re: [PATCH 8/9] branch: use ref-filter printing APIs

Karthik Nayak writes: > On Sat, Oct 3, 2015 at 6:11 PM, Matthieu Moy > wrote: >> Actually, this is not a performance-cricical piece of code at all, so I >> think it's even better to build an strbuf little by little using >> repeated

Re: [PATCH 8/9] branch: use ref-filter printing APIs

Karthik Nayak writes: > - if (upstream_is_gone) { > - if (show_upstream_ref) > - strbuf_addf(stat, _("[%s: gone]"), fancy.buf); The old string was translated, and you're replacing it with one which isn't. I'm not a big fan of