Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

2018-11-02 Thread Duy Nguyen
On Sat, Nov 3, 2018 at 1:38 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > > On Fri, Nov 2, 2018 at 2:32 PM Ben Peart wrote: > >> > >> From: Ben Peart > >> > >> During an "add", a call is made to run_diff_files() which calls > >> check_remove() for each index-entry. The preload_index()

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

2018-11-02 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Nov 2, 2018 at 2:32 PM Ben Peart wrote: >> >> From: Ben Peart >> >> During an "add", a call is made to run_diff_files() which calls >> check_remove() for each index-entry. The preload_index() code distributes >> some of the costs across multiple threads. > >

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

2018-11-02 Thread Ben Peart
On 11/2/2018 11:23 AM, Junio C Hamano wrote: Ben Peart writes: From: Ben Peart During an "add", a call is made to run_diff_files() which calls check_remove() for each index-entry. The preload_index() code distributes some of the costs across multiple threads. Nice. I peeked around

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

2018-11-02 Thread Duy Nguyen
On Fri, Nov 2, 2018 at 2:32 PM Ben Peart wrote: > > From: Ben Peart > > During an "add", a call is made to run_diff_files() which calls > check_remove() for each index-entry. The preload_index() code distributes > some of the costs across multiple threads. Instead of doing this site by site.

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

2018-11-02 Thread Junio C Hamano
Ben Peart writes: > From: Ben Peart > > During an "add", a call is made to run_diff_files() which calls > check_remove() for each index-entry. The preload_index() code > distributes some of the costs across multiple threads. Nice. I peeked around and noticed that we already do this in