Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Pranit Bauva writes: > On Tue, Jul 26, 2016 at 11:02 PM, Junio C Hamano wrote: >> Torsten Bögershausen writes: >> >>> On 07/25/2016 06:53 PM, Junio C Hamano wrote: Pranit Bauva writes: >>> >>>

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Junio, On Tue, Jul 26, 2016 at 11:02 PM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> On 07/25/2016 06:53 PM, Junio C Hamano wrote: >>> Pranit Bauva writes: >>> >> >>> +enum terms_defined { >> >>> +

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Torsten Bögershausen writes: > On 07/25/2016 06:53 PM, Junio C Hamano wrote: >> Pranit Bauva writes: >> > >>> +enum terms_defined { > >>> + TERM_BAD = 1, > >>> + TERM_GOOD = 2, > >>> + TERM_NEW = 4, > >>> +

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

On 07/25/2016 06:53 PM, Junio C Hamano wrote: Pranit Bauva writes: >>> +enum terms_defined { >>> + TERM_BAD = 1, >>> + TERM_GOOD = 2, >>> + TERM_NEW = 4, >>> + TERM_OLD = 8 >>> +}; >>> + >> >> What does TERM stand for ? The terms (words)

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

On Mon, Jul 25, 2016 at 6:53 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >>> And why are the defines 1,2,4,8 ? >>> It looks as if a #define bitmap may be a better choice here ? >>> How do we do these kind of bit-wise opions otherwise ? > > We

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Pranit Bauva writes: >>> +enum terms_defined { >>> + TERM_BAD = 1, >>> + TERM_GOOD = 2, >>> + TERM_NEW = 4, >>> + TERM_OLD = 8 >>> +}; >>> + >> >> What does TERM stand for ? The terms (words) used to denote the newer and the older parts of the

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Torsten, On Fri, Jul 22, 2016 at 7:59 AM, Torsten Bögershausen wrote: > > > On 07/20/2016 11:47 PM, Pranit Bauva wrote: >> >> Reimplement the `get_terms` and `bisect_terms` shell function in C and >> add `bisect-terms` subcommand to `git bisect--helper` to call it from >>

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

On 07/20/2016 11:47 PM, Pranit Bauva wrote: Reimplement the `get_terms` and `bisect_terms` shell function in C and add `bisect-terms` subcommand to `git bisect--helper` to call it from git-bisect.sh . In the shell version, the terms were identified by strings but in C version its done by bit