Re: [PATCH v2] Let submodule command exit with error status if path does not exist

2012-08-13 Thread Junio C Hamano
Heiko Voigt hvo...@hvoigt.net writes: How about I update CodingGuidelines according to the rules you suggested? Then other people know how we prefer bash functions and if statements to look like. OK. I was hoping that imitate surrounding code was sufficient, but it seems many parts of the

Re: [PATCH v2] Let submodule command exit with error status if path does not exist

2012-08-11 Thread Junio C Hamano
Heiko Voigt hvo...@hvoigt.net writes: I did not know that you prefer a space after the function name. I simply imitated the style from C and there we do not have spaces. It makes the style rules a bit more complicated. Wouldn't it be nicer to have the same as in C so we have less rules? I do