Re: [PATCH v2] gpg-interface: strip CR chars for Windows gpg2

On Sun, Nov 12, 2017 at 9:08 PM, Junio C Hamano wrote: > Eric Sunshine writes: >>> + size_t i, j; >>> + for (i = j = bottom; i < buffer->len; i++) >>> + if (!(i < buffer->len - 1 && >>> +

Re: [PATCH v2] gpg-interface: strip CR chars for Windows gpg2

Eric Sunshine writes: > Thanks for the re-roll... > > On Sun, Nov 12, 2017 at 8:07 AM, Jerzy Kozera wrote: >> This fixes the issue with newlines being \r\n and not being displayed >> correctly when using gpg2 for Windows, as reported at >>

Re: [PATCH v2] gpg-interface: strip CR chars for Windows gpg2

On Sun, Nov 12, 2017 at 01:07:10PM +, Jerzy Kozera wrote: > This fixes the issue with newlines being \r\n and not being displayed > correctly when using gpg2 for Windows, as reported at > https://github.com/git-for-windows/git/issues/1249 > > Issues with non-ASCII characters remain for

Re: [PATCH v2] gpg-interface: strip CR chars for Windows gpg2

Thanks for the re-roll... On Sun, Nov 12, 2017 at 8:07 AM, Jerzy Kozera wrote: > This fixes the issue with newlines being \r\n and not being displayed > correctly when using gpg2 for Windows, as reported at > https://github.com/git-for-windows/git/issues/1249 It's still