Re: [PATCH v2 1/1] Don't free remote->name after fetch

Keith McGuigan writes: > Yeah that was the only place I found where it was doing the strdup > already (and in that situation, it has to). All the other places just > grabbed remote->name. > > Yes, sorry, I can sign off on this. Do you want me to resend with the >

Re: [PATCH v2 1/1] Don't free remote->name after fetch

Yeah that was the only place I found where it was doing the strdup already (and in that situation, it has to). All the other places just grabbed remote->name. Yes, sorry, I can sign off on this. Do you want me to resend with the header in place, or is this confirmation good enough? -- - Keith

Re: [PATCH v2 1/1] Don't free remote->name after fetch

kmcgui...@twopensource.com writes: > From: Keith McGuigan > > Make fetch's string_list of remote names owns all of its string items > (strdup'ing when necessary) so that it can deallocate them safely when > clearing. > > --- OK. When I pointed out the call to