Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-24 Thread Christian Couder
On Sat, May 14, 2016 at 8:27 PM, Junio C Hamano wrote: > Christian Couder writes: > >> On Thu, May 12, 2016 at 10:43 PM, Junio C Hamano wrote: >>> Junio C Hamano writes: >>> Up to this point, the conversion looks quite sensible, even though I think the organization of fields in apply_

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-24 Thread Christian Couder
On Fri, May 13, 2016 at 9:42 PM, Christian Couder wrote: > On Thu, May 12, 2016 at 9:56 PM, Junio C Hamano wrote: >> Christian Couder writes: >> >>> This is just a small cleanup. >> >> ... which may have been better happened at 09/94. > > Ok, I will squash it in 09/94. This has been done in the

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-14 Thread Junio C Hamano
Christian Couder writes: > On Thu, May 12, 2016 at 10:43 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> Up to this point, the conversion looks quite sensible, even though I >>> think the organization of fields in apply_state do not look logical. >> >> I'd stop here for now, as every

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-13 Thread Christian Couder
On Thu, May 12, 2016 at 10:43 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Up to this point, the conversion looks quite sensible, even though I >> think the organization of fields in apply_state do not look logical. > > I'd stop here for now, as everything before this step looks > unco

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-13 Thread Christian Couder
On Thu, May 12, 2016 at 9:56 PM, Junio C Hamano wrote: > Christian Couder writes: > >> This is just a small cleanup. > > ... which may have been better happened at 09/94. Ok, I will squash it in 09/94. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-12 Thread Junio C Hamano
Junio C Hamano writes: > Up to this point, the conversion looks quite sensible, even though I > think the organization of fields in apply_state do not look logical. I'd stop here for now, as everything before this step looks uncontroversial. Anybody whose tasked to move the global state for the

Re: [PATCH v2 48/94] builtin/apply: rename 'prefix_' parameter to 'prefix'

2016-05-12 Thread Junio C Hamano
Christian Couder writes: > This is just a small cleanup. ... which may have been better happened at 09/94. Up to this point, the conversion looks quite sensible, even though I think the organization of fields in apply_state do not look logical. -- To unsubscribe from this list: send the line "