On Mon, Nov 27, 2017 at 06:05:20PM -0500, Jeff King wrote:
> On Mon, Nov 27, 2017 at 08:09:32PM +, brian m. carlson wrote:
>
> > > Show a message in the original terminal and get rid of it when the
> > > editor returns.
> > [...]
> >
> > Sorry for coming to the topic so late, but it occurred
> On 28 Nov 2017, at 00:18, Junio C Hamano wrote:
>
> lars.schnei...@autodesk.com writes:
>
>> diff to v2:
>>- shortened and localized the "waiting" message
>>- detect "emacsclient" and suppress "waiting" message
>
> Thanks for moving this forward.
>
>
>> +
> On 28 Nov 2017, at 00:05, Jeff King wrote:
>
> On Mon, Nov 27, 2017 at 08:09:32PM +, brian m. carlson wrote:
>
>>> Show a message in the original terminal and get rid of it when the
>>> editor returns.
>> [...]
>>
>> Sorry for coming to the topic so late, but it occurred
Jeff King writes:
> ... "if we need advice.*, that is a good sign that the
> feature is mis-designed".
>
> Let me elaborate a bit on the latter.
>
> My gut feeling is that this is absolutely the wrong place to put a
> message like this
> The right place for this message, IMHO,
lars.schnei...@autodesk.com writes:
> diff to v2:
> - shortened and localized the "waiting" message
> - detect "emacsclient" and suppress "waiting" message
Thanks for moving this forward.
> + static const char *close_notice = NULL;
Because this thing is "static", the
On Mon, Nov 27, 2017 at 08:09:32PM +, brian m. carlson wrote:
> > Show a message in the original terminal and get rid of it when the
> > editor returns.
> [...]
>
> Sorry for coming to the topic so late, but it occurred to me that we
> might want to conditionalize this on an advice.* flag.
On Mon, Nov 27, 2017 at 02:47:16PM +0100, lars.schnei...@autodesk.com wrote:
> From: Junio C Hamano
>
> When a graphical GIT_EDITOR is spawned by a Git command that opens
> and waits for user input (e.g. "git rebase -i"), then the editor window
> might be obscured by other
> On 27 Nov 2017, at 19:36, Eric Sunshine wrote:
>
> On Mon, Nov 27, 2017 at 8:47 AM, wrote:
>> When a graphical GIT_EDITOR is spawned by a Git command that opens
>> and waits for user input (e.g. "git rebase -i"), then the editor window
On Mon, Nov 27, 2017 at 8:47 AM, wrote:
> When a graphical GIT_EDITOR is spawned by a Git command that opens
> and waits for user input (e.g. "git rebase -i"), then the editor window
> might be obscured by other windows. The user may be left staring at the
> original
On Monday 27 November 2017 07:17 PM, lars.schnei...@autodesk.com wrote:
Show a message in the original terminal and get rid of it when the
editor returns.
"... except in the case when an error occurs." could be included if needed.
+ static const char *close_notice = NULL;
+
10 matches
Mail list logo