Re: [PATCH v3 1/2] sequencer: handle errors in read_author_ident()

2018-08-03 Thread Junio C Hamano
Eric Sunshine writes: > I think this patch can be simplified considerably by shifting one's > perspective. If we admit that read_author_ident() is already correctly > reporting an error by returning NULL (which is exactly what it is > doing), then the bug is is purely on the calling side; namely,

Re: [PATCH v3 1/2] sequencer: handle errors in read_author_ident()

2018-08-03 Thread Eric Sunshine
On Thu, Aug 2, 2018 at 7:20 AM Phillip Wood wrote: > The calling code did not treat NULL as an error. Instead NULL caused > it to fallback to using the default author when creating the new > commit. This changed the date and potentially the author of the > commit which corrupted the author data co