Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-06-21 Thread Jeff King
On Fri, May 13, 2016 at 03:25:58PM +0200, Johannes Schindelin wrote: > This patch makes perf-lib.sh more robust so that it can run correctly > even inside a worktree. For example, it assumed that $GIT_DIR/objects is > the objects directory (which is not the case for worktrees) and it used > the

Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-05-31 Thread Junio C Hamano
René Scharfe writes: >>> I fear that interacts badly with the `cd "$repo"` I introduced later >>> (replacing a `cd ..`)... > > Oh, right, it does if $repo is a relative path. > >> What do you want to do then? For now before -rc1 we can revert the >> whole thing so that we can get

Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-05-30 Thread René Scharfe
Am 30.05.2016 um 20:03 schrieb Junio C Hamano: > Johannes Schindelin writes: > >>> This breaks perf for the non-worktree case: >> >> Oh drats! >> >>> lsr@debian:~/src/git/t/perf$ make >>> rm -rf test-results >>> ./run >>> === Running 12 tests in this tree === >>> cp:

Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-05-30 Thread Junio C Hamano
Johannes Schindelin writes: >> This breaks perf for the non-worktree case: > > Oh drats! > >> lsr@debian:~/src/git/t/perf$ make >> rm -rf test-results >> ./run >> === Running 12 tests in this tree === >> cp: cannot stat '.git/objects': No such file or directory >>

Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-05-30 Thread Johannes Schindelin
Hi René, On Sun, 29 May 2016, René Scharfe wrote: > Am 13.05.2016 um 15:25 schrieb Johannes Schindelin: > > This patch makes perf-lib.sh more robust so that it can run correctly > > even inside a worktree. For example, it assumed that $GIT_DIR/objects is > > the objects directory (which is not

Re: [PATCH v3 2/3] perf: make the tests work in worktrees

2016-05-29 Thread René Scharfe
Am 13.05.2016 um 15:25 schrieb Johannes Schindelin: > This patch makes perf-lib.sh more robust so that it can run correctly > even inside a worktree. For example, it assumed that $GIT_DIR/objects is > the objects directory (which is not the case for worktrees) and it used > the commondir file