Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 06 2017, Ævar Arnfjörð Bjarmason jotted: > On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques wrote: >> On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: >>> >>> Johannes Sixt writes: >>> >>> > The updated series works for me now.

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques wrote: > On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: >> >> Johannes Sixt writes: >> >> > The updated series works for me now. Nevertheless, I suggest to squash >> > in the following

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: > > Johannes Sixt writes: > > > The updated series works for me now. Nevertheless, I suggest to squash > > in the following change to protect against IFS and globbing characters in > > $INSTLIBDIR. > > Yeah,

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Johannes Sixt writes: > The updated series works for me now. Nevertheless, I suggest to squash > in the following change to protect against IFS and globbing characters in > $INSTLIBDIR. Yeah, that is very sensible. > diff --git a/Makefile b/Makefile > index

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Am 05.12.2017 um 22:35 schrieb Junio C Hamano: > Dan Jacques writes: > >> Thanks for checking! The patch that you quoted above looks like it's from >> this "v4" thread; however, the patch that you are diffing against in your >> latest reply seems like it is from an earlier

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Dan Jacques writes: > Thanks for checking! The patch that you quoted above looks like it's from > this "v4" thread; however, the patch that you are diffing against in your > latest reply seems like it is from an earlier version. > > I believe that the $(pathsep) changes in your

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Johannes Sixt wrote: > I don't know what I tested last week; most likely not the version of the > patch I quoted above. > > Today's version, with the tip at 5d7f59c391ce, is definitely bogus > with its quoting. It needs the patch below, otherwise an unquoted > semicolon may be expanded from

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Johannes Sixt writes: > Today's version, with the tip at 5d7f59c391ce, is definitely bogus > with its quoting. It needs the patch below, otherwise an unquoted > semicolon may be expanded from $(pathsep). This would terminate the sed > command, of course. Of course ;-) Somehow I

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Am 01.12.2017 um 18:25 schrieb Johannes Sixt: > Am 01.12.2017 um 18:13 schrieb Johannes Schindelin: >> Hi Hannes, >> >> On Fri, 1 Dec 2017, Johannes Sixt wrote: >> >>> Am 29.11.2017 um 16:56 schrieb Dan Jacques: @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE     echo "$$FLAGS"

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Sun, Dec 03 2017, Junio C. Hamano jotted: > Johannes Sixt writes: > >>> + sed -e 's=@@PATHSEP@@=$(pathsep)=g' \ >> >> This doesn't work, unfortunately. When $(pathsep) is ';', we get an >> incomplete sed expression because ';' is also a command separator in >> the sed

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Johannes Sixt writes: >> +sed -e 's=@@PATHSEP@@=$(pathsep)=g' \ > > This doesn't work, unfortunately. When $(pathsep) is ';', we get an > incomplete sed expression because ';' is also a command separator in > the sed language. It is correct that ';' can be and does get used

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Dez 01 2017, Dan Jacques wrote: > I am not a `sed` wizard, but perhaps the tool is ignoring the semicolon > because > it's in the middle of the "s" expression? The shell may similarly be ignoring > it > because it's nested in between single-quotes? As far as POSIX is

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Fri, 1 Dec 2017, Johannes Sixt wrote: >>> This doesn't work, unfortunately. When $(pathsep) is ';', we get an >>> incomplete sed expression because ';' is also a command separator in the >>> sed language. >> >> Funny, I tried this also with ';' as pathsep, and it worked in the Git for >>

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Am 01.12.2017 um 18:13 schrieb Johannes Schindelin: Hi Hannes, On Fri, 1 Dec 2017, Johannes Sixt wrote: Am 29.11.2017 um 16:56 schrieb Dan Jacques: @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE echo "$$FLAGS" >$@; \ fi +GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE)

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Hi Hannes, On Fri, 1 Dec 2017, Johannes Sixt wrote: > Am 29.11.2017 um 16:56 schrieb Dan Jacques: > > @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE > > echo "$$FLAGS" >$@; \ > >fi > > +GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak > > Makefile > >

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Am 29.11.2017 um 16:56 schrieb Dan Jacques: @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE echo "$$FLAGS" >$@; \ fi +GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile + $(QUIET_GEN)$(RM) $@ && \ + INSTLIBDIR=`MAKEFLAGS=