Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

Benoît Person benoit.per...@ensimag.fr writes: Do we want to add that ':' unconditionally? Could GITPERLLIB be empty? For now, GITPERLLIB is only used in that kind of statements: use lib (split(/:/, $ENV{GITPERLLIB} || ... )); The trailing ':' does not really matter, split will ignore it.

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

For now, GITPERLLIB is only used in that kind of statements: use lib (split(/:/, $ENV{GITPERLLIB} || ... )); The trailing ':' does not really matter, split will ignore it. That may be true with the current use, but For now leaves funny taste, doesn't it? definitely. For me, the issue was

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

On 07/03/2013 12:39 AM, benoit.per...@ensimag.fr wrote: From: Benoit Person benoit.per...@ensimag.fr For now, bin-wrappers (based on wrap-for-bin.sh) redefine some environnement variables (like $GITPERLLIB). If we want to chain to those scripts and define one of those variables before, our

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

benoit.per...@ensimag.fr writes: diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh index 53a8dd0..dbebe49 100644 --- a/wrap-for-bin.sh +++ b/wrap-for-bin.sh @@ -14,7 +14,7 @@ else GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' export GIT_TEMPLATE_DIR fi

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

Matthieu Moy matthieu@grenoble-inp.fr writes: benoit.per...@ensimag.fr writes: diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh index 53a8dd0..dbebe49 100644 --- a/wrap-for-bin.sh +++ b/wrap-for-bin.sh @@ -14,7 +14,7 @@ else GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt'

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@grenoble-inp.fr writes: benoit.per...@ensimag.fr writes: diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh index 53a8dd0..dbebe49 100644 --- a/wrap-for-bin.sh +++ b/wrap-for-bin.sh @@ -14,7 +14,7 @@ else

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

Matthieu Moy matthieu@grenoble-inp.fr writes: I don't get it. It Git Mediawiki's tests, the tests scripts source test-lib.sh, that unsets GITPERLLIB. Then, it calls the mw-to-git/bin-wrapper/git that sets it properly, and calls the toplevel's bin-wrapper. Ah, OK. I somehow was assuming

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

benoit.per...@ensimag.fr writes: From: Benoit Person benoit.per...@ensimag.fr For now, bin-wrappers (based on wrap-for-bin.sh) redefine some environnement variables (like $GITPERLLIB). If we want to chain to those scripts and define one of those variables before, our changes will be

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

Do we want to add that ':' unconditionally? Could GITPERLLIB be empty? For now, GITPERLLIB is only used in that kind of statements: use lib (split(/:/, $ENV{GITPERLLIB} || ... )); The trailing ':' does not really matter, split will ignore it. With the current codebase, I think it's nicer to