Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-28 Thread Junio C Hamano
Junio C Hamano writes: > I am talking about a case where > > cd repo > cd untracked > git submodule --recurse-submodules --read-from=file > > wants to run , using information stored in repo/untracked/file, > and work on submodules repo/sub and

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Fri, Mar 25, 2016 at 4:15 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Of course by using -C, you might notice that repo/sub/untracked does >>> not exist, but that is not a proper error checking---what if the >>> submodule at repo/sub does

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: >> Of course by using -C, you might notice that repo/sub/untracked does >> not exist, but that is not a proper error checking---what if the >> submodule at repo/sub does have a directory with that name? IOW, >> the computation that gave

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Fri, Mar 25, 2016 at 3:39 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The replacement works fine in all tests except for the recursive >> tests as then the chdir is an important detail. In the submodule >> there is no $wt_prefix (as it is the

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: > The replacement works fine in all tests except for the recursive > tests as then the chdir is an important detail. In the submodule > there is no $wt_prefix (as it is the parents' wt_prefix we passed in), So the real reason is that we may tweak

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Stefan Beller
On Fri, Mar 25, 2016 at 1:54 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> This helper is called from the root level of the superproject's >> working tree (after cd_to_toplevel is done), and has options like >> --url. If the user named --url with

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Junio C Hamano writes: > This helper is called from the root level of the superproject's > working tree (after cd_to_toplevel is done), and has options like > --url. If the user named --url with a relative pathname to a local > repository directory (or a bundle file),

Re: [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option

2016-03-25 Thread Junio C Hamano
Stefan Beller writes: > In the rewrite from shell to C (ee8838d157761, 2015-09-08, submodule: > rewrite `module_clone` shell function in C), we never made use of the > prefix. Probably it sneaked in as module_list which was converted in the > same series had the prefix as