Re: [PATCHv5 3/3] submodule: Reimplement `module_clone` shell function in C

2015-09-08 Thread Stefan Beller
On Thu, Sep 3, 2015 at 3:07 PM, Junio C Hamano wrote: >> + >> + cp.no_stdin = 1; >> + cp.no_stdout = 1; >> + cp.no_stderr = 1; > > Output from "git clone" is not shown, regardless of --quiet option? Removed that. >> + argc = parse_options(argc, argv, prefix,

Re: [PATCHv5 3/3] submodule: Reimplement `module_clone` shell function in C

2015-09-08 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Sep 3, 2015 at 3:07 PM, Junio C Hamano wrote: >>> + >>> + cp.no_stdin = 1; >>> + cp.no_stdout = 1; >>> + cp.no_stderr = 1; >> >> Output from "git clone" is not shown, regardless of --quiet option? > > Removed

Re: [PATCHv5 3/3] submodule: Reimplement `module_clone` shell function in C

2015-09-03 Thread Junio C Hamano
Stefan Beller writes: > @@ -119,6 +120,140 @@ static int module_name(int argc, const char **argv, > const char *prefix) > > return 0; > } > +static int clone_submodule(const char *path, const char *gitdir, const char > *url, > +const char

Re: [PATCHv5 3/3] submodule: Reimplement `module_clone` shell function in C

2015-09-03 Thread Eric Sunshine
On Wed, Sep 2, 2015 at 5:42 PM, Stefan Beller wrote: > This reimplements the helper function `module_clone` in shell > in C as `clone`. This functionality is needed for converting > `git submodule update` later on, which we want to add threading > to. > > Signed-off-by: Stefan