Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

2018-07-09 Thread Beat Bolli
On 09.07.18 23:34, Junio C Hamano wrote: > Beat Bolli writes: > >> The marco GIT_PATH_FUNC expands to a complete statement including the >> semicolon. Remove two extra trailing semicolons. > > Wait a bit. The observation in the log message and the > implementation of GIT_PATH_FUNC() do not

Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

2018-07-09 Thread Junio C Hamano
Beat Bolli writes: > The marco GIT_PATH_FUNC expands to a complete statement including the > semicolon. Remove two extra trailing semicolons. Wait a bit. The observation in the log message and the implementation of GIT_PATH_FUNC() do not match. #define GIT_PATH_FUNC(func, filename) \

Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

2018-07-09 Thread ig
Am 08.07.2018 23:17, schrieb Philip Oakley: From: "Eric Sunshine" To: "Beat Bolli" On Sun, Jul 8, 2018 at 10:44 AM Beat Bolli wrote: The marco GIT_PATH_FUNC expands to a complete statement including the s/marco/macro/ ACK. In addition, the whole sentence is wrong: GIT_PATH_FUNC defines

Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

2018-07-08 Thread Philip Oakley
From: "Eric Sunshine" To: "Beat Bolli" On Sun, Jul 8, 2018 at 10:44 AM Beat Bolli wrote: The marco GIT_PATH_FUNC expands to a complete statement including the s/marco/macro/ semicolon. Remove two extra trailing semicolons. Signed-off-by: Beat Bolli --- sequencer.c | 4 ++-- 1 file

Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

2018-07-08 Thread Eric Sunshine
On Sun, Jul 8, 2018 at 10:44 AM Beat Bolli wrote: > The marco GIT_PATH_FUNC expands to a complete statement including the > semicolon. Remove two extra trailing semicolons. > > Signed-off-by: Beat Bolli > --- > sequencer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) While