Re: [RFC PATCH v2 04/12] submodule--helper: add a new 'config' subcommand

2018-08-03 Thread Antonio Ospite
On Thu, 2 Aug 2018 15:20:33 -0400 Jeff King wrote: > On Thu, Aug 02, 2018 at 11:47:30AM -0700, Stefan Beller wrote: > > > > +static int module_config(int argc, const char **argv, const char *prefix) > > > +{ > > > + if (argc < 2 || argc > 3) > > > + die("submodule--helper

Re: [RFC PATCH v2 04/12] submodule--helper: add a new 'config' subcommand

2018-08-02 Thread Jeff King
On Thu, Aug 02, 2018 at 11:47:30AM -0700, Stefan Beller wrote: > > +static int module_config(int argc, const char **argv, const char *prefix) > > +{ > > + if (argc < 2 || argc > 3) > > + die("submodule--helper config takes 1 or 2 arguments: name > > [value]"); > > + > > +

Re: [RFC PATCH v2 04/12] submodule--helper: add a new 'config' subcommand

2018-08-02 Thread Stefan Beller
On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite wrote: > > Add a new 'config' subcommand to 'submodule--helper', this extra level > of indirection makes it possible to add some flexibility to how the > submodules configuration is handled. > > Signed-off-by: Antonio Ospite > --- > > Note that the