Re: Alternative to manual editing with git add --patch

2015-10-15 Thread Johannes Schindelin
Hi Sven & Junio, On Thu, 15 Oct 2015, Sven Helmberger wrote: > Am 14.10.2015 um 19:50 schrieb Junio C Hamano: > > Sven Helmberger writes: > > > > As a quick-and-dirty change, you could invent a new variant of > > 's'plit that breaks a N-line hunk into N hunks with

Re: Alternative to manual editing with git add --patch

2015-10-15 Thread Johannes Schindelin
Hi Sven, On Thu, 15 Oct 2015, Sven Helmberger wrote: > Am 15.10.2015 um 12:11 schrieb Johannes Schindelin: > > > > This is all technically sound. From a usability perspective I would wish > > more for a way to exclude or filter the lines by a pattern. > > Why not do both? Because sometimes

Re: Alternative to manual editing with git add --patch

2015-10-15 Thread Sven Helmberger
Am 15.10.2015 um 17:06 schrieb Johannes Schindelin: > > Because sometimes more is less. If users are overwhelmed with many, many > options, they are *less* likely to benefit from the few that are easy to > use because they won't find out about them. > Going from "I want to split at 'x'" to

Re: Alternative to manual editing with git add --patch

2015-10-15 Thread Sven Helmberger
Am 15.10.2015 um 12:11 schrieb Johannes Schindelin: > > This is all technically sound. From a usability perspective I would wish > more for a way to exclude or filter the lines by a pattern. Why not do both? The only thing that is unfortunate is that the "/" already is a command. Which would

Re: Alternative to manual editing with git add --patch

2015-10-14 Thread Johannes Schindelin
Hi Sven, On 2015-10-14 17:07, Sven Helmberger wrote: > What I then often encountered was the situation where I happened to have > inserted consecutive lines of code that conceptually belong to different > commits. Normally I can nicely split patches, but not in this case, > making manually

Re: Alternative to manual editing with git add --patch

2015-10-14 Thread Junio C Hamano
Sven Helmberger writes: > I hope this hasn't been discussed before. > > I'm a big fan of cleanliness in commits and therefore often use git add > --patch to sort code changes I made into the right commits etc. > > What I then often encountered was the situation where I

Re: Alternative to manual editing with git add --patch

2015-10-14 Thread Matthieu Moy
Sven Helmberger writes: > Hello, > > I hope this hasn't been discussed before. > > I'm a big fan of cleanliness in commits and therefore often use git add > --patch to sort code changes I made into the right commits etc. > > What I then often encountered was the situation

Re: Alternative to manual editing with git add --patch

2015-10-14 Thread Sven Helmberger
Am 14.10.2015 um 19:50 schrieb Junio C Hamano: > Sven Helmberger writes: > > As a quick-and-dirty change, you could invent a new variant of > 's'plit that breaks a N-line hunk into N hunks with 1-line each, but > obviously that would not be a pleasant-enough UI to be