Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Jacob Keller
On Wed, Jul 22, 2015 at 10:48 PM, Jeff King p...@peff.net wrote: On Wed, Jul 22, 2015 at 10:14:45PM -0700, Jeff King wrote: Script writers should not care here, because they should not be parsing the output of the porcelain log command in the first place. It already has many gotchas (e.g.,

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Jeff King
On Thu, Jul 23, 2015 at 11:53:37AM +0200, Michael J Gruber wrote: That reminds me of my attempt to add those categories to the man pages of each command (rather than just to that of git) so that users know where they landed. It died off, though: I preferred just specifying the category (maybe

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Junio C Hamano
Jeff King p...@peff.net writes: I am sympathetic, though. There are some things that git-log can do that rev-list cannot, so people end up using it in scripts. I think you can avoid it with a rev-list | diff-tree pipeline, though I'm not 100% sure if that covers all cases. But I would much

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Jacob Keller
On Wed, Jul 22, 2015 at 11:53 PM, Jeff King p...@peff.net wrote: man git already has such a list (which is generated from the annotations in command-list.txt). But I agree that it would probably be helpful to point people directly from git log to git rev-list and vice versa. -Peff That's

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Jeff King
On Wed, Jul 22, 2015 at 11:32:49PM -0700, Jacob Keller wrote: Agreed. Fix the plumbing instead and document how/why to use it instead of the porcelain. We might do better to help clearly document which commands are porcelain and which are plumbing maybe by referencing which plumbings to use

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-23 Thread Michael J Gruber
Jacob Keller venit, vidit, dixit 23.07.2015 08:55: On Wed, Jul 22, 2015 at 11:53 PM, Jeff King p...@peff.net wrote: man git already has such a list (which is generated from the annotations in command-list.txt). But I agree that it would probably be helpful to point people directly from git log

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-22 Thread Jeff King
On Wed, Jul 22, 2015 at 09:40:10PM -0700, David Aguilar wrote: On Wed, Jul 22, 2015 at 06:23:44PM -0700, Jeff King wrote: This patch adds an option to turn on --first-parent all the time, along with the corresponding --no-first-parent to disable it. [Putting on my scripter hat] I

Re: Config variables and scripting // was Re: [RFC/PATCH] log: add log.firstparent option

2015-07-22 Thread Jeff King
On Wed, Jul 22, 2015 at 10:14:45PM -0700, Jeff King wrote: Script writers should not care here, because they should not be parsing the output of the porcelain log command in the first place. It already has many gotchas (e.g., log.date, log.abbrevCommit). I am sympathetic, though. There are