Am 06.10.19 um 01:41 schrieb Junio C Hamano:
> René Scharfe writes:
>> This one here requires one more piece of information, though, namely our
>> convention of wrapping header files in guard defines to make repeated
>> includes of them no-ops. We do that for those removed by the patch, but
>> we
René Scharfe writes:
> It works best for changes whose effects are constrained to within the
> affected functions, but have crucial information located outside the
> three default lines of context. An example would be a change at the end
> of a function for which a reviewer might need to know th
Am 04.10.19 um 01:15 schrieb Junio C Hamano:
> René Scharfe writes:
>
>> Found with "git grep '^#include ' '*.c' | sort | uniq -d".
>>
>> Signed-off-by: René Scharfe
>> ---
>> Patch formatted with --function-context for easier review.
>
> I have a mixed feelings about that.
>
> The only audience
René Scharfe writes:
> Found with "git grep '^#include ' '*.c' | sort | uniq -d".
>
> Signed-off-by: René Scharfe
> ---
> Patch formatted with --function-context for easier review.
I have a mixed feelings about that.
The only audience benefitted by --function-context patch are those
who read t
4 matches
Mail list logo