Re: Test t/t7502-commit.sh failed

2012-07-26 Thread Jeff King
On Thu, Jul 26, 2012 at 02:27:52PM +0800, Jiang Xin wrote: Test t/t7502-commit.sh failed. I guess it's commit v1.7.9.7-1-gf20f387 which breaks it. $ git log -1 --oneline --stat v1.7.9.7-1-gf20f387 f20f commit: check committer identity more strictly builtin/commit.c | 2 +-

Re: Test t/t7502-commit.sh failed

2012-07-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Thu, Jul 26, 2012 at 02:27:52PM +0800, Jiang Xin wrote: ... not ok - 21 committer is automatic # # # echo negative # ( # sane_unset GIT_COMMITTER_EMAIL # sane_unset

Re: Test t/t7502-commit.sh failed

2012-07-26 Thread Jeff King
On Thu, Jul 26, 2012 at 09:34:27AM -0700, Junio C Hamano wrote: not ok - 21 committer is automatic [...] I am not sure that the test is really all that useful. The point seems to be that we fall back to some kind of system-based ident, but that is not portable. I think the point is to

Re: Test t/t7502-commit.sh failed

2012-07-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: Yes, and they are given that chance. This is not about the behavior of git, but about stupid assumptions by the test. OK. I'm close to finished with a series that I think will at least make it better. Stay tuned. ;-) -- To unsubscribe from this list: send