Re: Test failures with GNU grep 2.23

On Fri, Feb 19, 2016 at 07:23:11PM +, John Keeping wrote: > I suspect that any grep that lacks "-a" also lacks binary file handling > that will break these tests. I found a Solaris grep that doesn't > support "-a" and it treats these files as text. > > From that perspective, it would be

Re: Test failures with GNU grep 2.23

On Fri, Feb 19, 2016 at 09:38:17AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have > > it, so between that and GNU, I think most systems are covered. We could > > do: > > > > test_lazy_prereq GREP_A '

Re: Test failures with GNU grep 2.23

On Fri, Feb 19, 2016 at 09:38:17AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have > > it, so between that and GNU, I think most systems are covered. We could > > do: > > > > test_lazy_prereq GREP_A

Re: Test failures with GNU grep 2.23

Jeff King writes: > Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have > it, so between that and GNU, I think most systems are covered. We could > do: > > test_lazy_prereq GREP_A ' > echo foo | grep -a foo > ' > > and mark these tests with it. I'd

Re: Test failures with GNU grep 2.23

On Fri, Feb 19, 2016 at 6:59 AM, Jeff King wrote: > On Sun, Feb 07, 2016 at 04:25:40PM +, John Keeping wrote: >> The following patch fixes the tests for me, but I wonder if "-a" is >> supported on all target platforms (it's not in POSIX, which specifies >> that the "input files

Re: Test failures with GNU grep 2.23

On Sun, Feb 07, 2016 at 04:25:40PM +, John Keeping wrote: > It seems that binary file detection has changed in GNU grep 2.23 as a > result of commit 40ed879 (grep: fix bug with with invalid unibyte > sequence). I read this bug report a while ago when you posted it, but happily ignored it