Re: SHA1 collision in production repo?! (probably not)

2017-09-12 Thread Jeff King
On Tue, Sep 12, 2017 at 06:18:32PM +0200, Lars Schneider wrote: > we are seeing this now in Git 2.14.1: > > ... > error: inflate: data stream error (unknown compression method) > error: unable to unpack 7b513f98a66ef9488e516e7abbc246438597c6d5 header > error: inflate: data stream error (unknown c

Re: SHA1 collision in production repo?! (probably not)

2017-09-12 Thread Lars Schneider
> On 31 Mar 2017, at 19:45, Jeff King wrote: > > On Fri, Mar 31, 2017 at 10:35:06AM -0700, Junio C Hamano wrote: > >> Lars Schneider writes: >> >>> Hi, >>> >>> I just got a report with the following output after a "git fetch" operation >>> using Git 2.11.0.windows.3 [1]: >>> >>> remote: Cou

Re: SHA1 collision in production repo?! (probably not)

2017-04-01 Thread Jeff King
On Fri, Mar 31, 2017 at 02:16:29PM -0700, Junio C Hamano wrote: > Before we forget... > > -- >8 -- > From: Jeff King > > When sha1_loose_object_info() finds that a loose object file cannot > be stat(2)ed or mmap(2)ed, it returns -1 to signal an error to the > caller. However, if it found that

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Junio C Hamano
Before we forget... -- >8 -- From: Jeff King When sha1_loose_object_info() finds that a loose object file cannot be stat(2)ed or mmap(2)ed, it returns -1 to signal an error to the caller. However, if it found that the loose object file is corrupt and the object data cannot be used from it, it

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Jeff King
On Fri, Mar 31, 2017 at 11:19:54AM -0700, Junio C Hamano wrote: > > Er, no, that's totally wrong. "status' may be holding the type. It > > should really be: > > > > return status < 0 ? status : 0; > > Sounds more like it. The only caller will say "ah, that object is > not available to us---let

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Junio C Hamano
Jeff King writes: > On Fri, Mar 31, 2017 at 01:45:15PM -0400, Jeff King wrote: > >> I suspect this may improve things, but I haven't dug deeper to see if >> there are unwanted side effects, or if there are other spots that need >> similar treatment. >> >> diff --git a/sha1_file.c b/sha1_file.c >

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Jeff King
On Fri, Mar 31, 2017 at 01:45:15PM -0400, Jeff King wrote: > I suspect this may improve things, but I haven't dug deeper to see if > there are unwanted side effects, or if there are other spots that need > similar treatment. > > diff --git a/sha1_file.c b/sha1_file.c > index 43990dec7..38411f90b

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Jeff King
On Fri, Mar 31, 2017 at 10:35:06AM -0700, Junio C Hamano wrote: > Lars Schneider writes: > > > Hi, > > > > I just got a report with the following output after a "git fetch" operation > > using Git 2.11.0.windows.3 [1]: > > > > remote: Counting objects: 5922, done. > > remote: Compressing objects

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Junio C Hamano
Lars Schneider writes: > Hi, > > I just got a report with the following output after a "git fetch" operation > using Git 2.11.0.windows.3 [1]: > > remote: Counting objects: 5922, done. > remote: Compressing objects: 100% (14/14), done. > error: inflate: data stream error (unknown compression meth

Re: SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Jeff King
On Fri, Mar 31, 2017 at 06:05:17PM +0200, Lars Schneider wrote: > I just got a report with the following output after a "git fetch" operation > using Git 2.11.0.windows.3 [1]: > > remote: Counting objects: 5922, done. > remote: Compressing objects: 100% (14/14), done. > error: inflate: data strea

SHA1 collision in production repo?! (probably not)

2017-03-31 Thread Lars Schneider
Hi, I just got a report with the following output after a "git fetch" operation using Git 2.11.0.windows.3 [1]: remote: Counting objects: 5922, done. remote: Compressing objects: 100% (14/14), done. error: inflate: data stream error (unknown compression method) error: unable to unpack 6acd8f279a8