Re: Should git help respect the 'pager' setting?

2013-06-02 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: On Thu, May 30, 2013 at 10:38:59PM +0530, Ramkumar Ramachandra wrote: Matthieu Moy wrote: I find it a bit weird that Git sets the configuration for external commands, but it may make sense. No strong opinion here. I don't mean a setenv() kind of

Should git help respect the 'pager' setting?

2013-05-30 Thread Michael Campbell
I have my global git config pager set to 'cat', but when I do a git help command, it still uses a pager. This is especially irksome in emacs shell buffers, where I am most of the time. I know I can do a M-x man - git-whatever, but wondered if this was a bug or user error. (git --no-pager help

Re: Should git help respect the 'pager' setting?

2013-05-30 Thread Matthieu Moy
Michael Campbell michael.campb...@gmail.com writes: I have my global git config pager set to 'cat', but when I do a git help command, it still uses a pager. This is especially irksome in emacs shell buffers, where I am most of the time. I know I can do a M-x man - git-whatever, but wondered

Re: Should git help respect the 'pager' setting?

2013-05-30 Thread Matthieu Moy
Ramkumar Ramachandra artag...@gmail.com writes: It just needs to set $PAGER or $MANPAGER before the exec(), no? Yes, that should do the same as man -P. I would argue that it should do this. $GIT_PAGER works everywhere else, but obviously man has no knowledge about it. I find it a bit weird

Re: Should git help respect the 'pager' setting?

2013-05-30 Thread Ramkumar Ramachandra
Matthieu Moy wrote: I find it a bit weird that Git sets the configuration for external commands, but it may make sense. No strong opinion here. I don't mean a setenv() kind of thing: how would we unset it after that? Perhaps something like execvpe(), passing in the environment as an argument?

Re: Should git help respect the 'pager' setting?

2013-05-30 Thread John Keeping
On Thu, May 30, 2013 at 10:38:59PM +0530, Ramkumar Ramachandra wrote: Matthieu Moy wrote: I find it a bit weird that Git sets the configuration for external commands, but it may make sense. No strong opinion here. I don't mean a setenv() kind of thing: how would we unset it after that?