Re: Small issue with "add untracked" option of 'git add -i'

2017-06-21 Thread Kaartic Sivaraam
On Mon, 2017-06-12 at 10:59 -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > After prompting to get the list of desired files, if the user chose > > nothing, the message is shown.  "No untracked files chosen." is > > probably what the code wants to say, I would

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-21 Thread Kaartic Sivaraam
On Wed, 2017-06-21 at 06:52 +0200, Kevin Daudt wrote: > Did you make sure you used the git you built, and also the relevant > subcommands? > You got it. I apologise for any confusion caused here. I seemed to have accidentally given a build location in my custom build script, different from the

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-20 Thread Kevin Daudt
On Wed, Jun 21, 2017 at 08:25:26AM +0530, Kaartic Sivaraam wrote: > > I tried applying the patch and building it locally. For some reason I > couldn't see the change in effect. What could I be missing? > Did you make sure you used the git you built, and also the relevant subcommands? What does

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-20 Thread Kaartic Sivaraam
On Mon, 2017-06-12 at 10:59 -0700, Junio C Hamano wrote: > Together with your other wishes, perhaps something like this is what > you have in mind.  The original tried to throw in a blank line as a > separator to help interactive users to more easily tell the boundary > of blocks of text, but it

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-15 Thread Kaartic Sivaraam
On Wed, 2017-06-14 at 18:34 +0530, Kaartic Sivaraam wrote: > That's right. Though I'm not sure of the implementation, I guess the > following patch would make `git add -i` do what I thought it should. > A possible, probably better, alternative would be to make the empty state output more

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-14 Thread Kaartic Sivaraam
On Mon, 2017-06-12 at 10:59 -0700, Junio C Hamano wrote: > Together with your other wishes, perhaps something like this is what > you have in mind.  The original tried to throw in a blank line as a > separator to help interactive users to more easily tell the boundary > of blocks of text, but it

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-12 Thread Junio C Hamano
Junio C Hamano writes: > After prompting to get the list of desired files, if the user chose > nothing, the message is shown. "No untracked files chosen." is > probably what the code wants to say, I would think. Together with your other wishes, perhaps something like this

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-12 Thread Kaartic Sivaraam
On Mon, 2017-06-12 at 10:38 -0700, Junio C Hamano wrote: > After prompting to get the list of desired files, if the user chose > nothing, the message is shown.  "No untracked files chosen." is > probably what the code wants to say, I would think. > That does seem to be a more apt message to be

Re: Small issue with "add untracked" option of 'git add -i'

2017-06-12 Thread Junio C Hamano
Kaartic Sivaraam writes: > * He chooses to use 'git add -i' to stage changes > * He chooses option 4, accidentally, instead of option 5. He is shown > the following menu, > >> *** Commands *** >>   1: status   2: update   3: revert   4: add >> untracked

Small issue with "add untracked" option of 'git add -i'

2017-06-12 Thread Kaartic Sivaraam
Hello all, There seems to be a small issue with the output of the "add untracked" option of 'git add -i'. Consider the following scenario, * A user makes a change to a tracked file * His repo has a few untracked files which he has left it in that way intentionally * He chooses to use 'git add