Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-11 Thread Junio C Hamano
Jeff King writes: > Another difference I found is that "[\d]" matches a literal "\" or "d" > in ERE, but behaves like "[0-9]" in PCRE. I'll work up a patch based on > that. Wow, clever. Thanks.

Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-11 Thread Jeff King
On Tue, Jan 10, 2017 at 12:40:00PM +0100, Szabolcs Nagy wrote: > > > I'm not sure if musl is wrong for failing to complain about a > > > bogus regex. Generally making something that would break into > > > something that works is an OK way to extend the standard. So our > > > test is at fault for

Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-10 Thread Szabolcs Nagy
* A. Wilcox [2017-01-10 04:36:50 -0600]: > On 09/01/17 15:33, Jeff King wrote: > > The problem is that we are expecting the regex "\x{2b}" to complain > > in regcomp() (as an ERE), but it doesn't. And that probably _is_ > > related to musl, which is providing the libc

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-10 Thread A. Wilcox
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 (Hi, musl developers! Read on for some information regarding what began as a test failure during packaging of Git 2.7.3 that appears to be related to musl's regexp library.) On 09/01/17 05:27, Jeff King wrote: > Are you trying with a version of

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-09 Thread Jeff King
On Mon, Jan 09, 2017 at 02:05:44PM +0100, Andreas Schwab wrote: > On Jan 09 2017, "A. Wilcox" wrote: > > > Interestingly enough, you seem to be right. The failure is very > > bizarre and has nothing to do with system /bin/grep: > > > > test_must_fail: command

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-09 Thread Andreas Schwab
On Jan 09 2017, "A. Wilcox" wrote: > Interestingly enough, you seem to be right. The failure is very > bizarre and has nothing to do with system /bin/grep: > > test_must_fail: command succeeded: git grep -G -F -P -E a\x{2b}b\x{2a}c ab > not ok 142 - grep -G -F -P -E

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-09 Thread Jeff King
On Mon, Jan 09, 2017 at 04:51:22AM -0600, A. Wilcox wrote: > Interestingly enough, you seem to be right. The failure is very > bizarre and has nothing to do with system /bin/grep: > > test_must_fail: command succeeded: git grep -G -F -P -E a\x{2b}b\x{2a}c ab > not ok 142 - grep -G -F -P -E

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-09 Thread A. Wilcox
On 02/01/17 00:53, Jeff King wrote: > On Sat, Dec 31, 2016 at 10:59:11PM -0600, A. Wilcox wrote: > >> I'm attempting to package Git for our new Linux distribution and >> I have run in to a failure on our PowerPC builder while running >> the test suite. >> >> The PowerPC builder runs a tiny

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-01 Thread Jeff King
On Sat, Dec 31, 2016 at 10:59:11PM -0600, A. Wilcox wrote: > I'm attempting to package Git for our new Linux distribution and I > have run in to a failure on our PowerPC builder while running the test > suite. > > The PowerPC builder runs a tiny version of grep(1) that was not built > with PCRE.

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-01 Thread Torsten Bögershausen
On 01.01.17 05:59, A. Wilcox wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hello! > > I'm attempting to package Git for our new Linux distribution and I > have run in to a failure on our PowerPC builder while running the test > suite. > > The PowerPC builder runs a tiny version

Test failures when Git is built with libpcre and grep is built without it

2016-12-31 Thread A. Wilcox
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello! I'm attempting to package Git for our new Linux distribution and I have run in to a failure on our PowerPC builder while running the test suite. The PowerPC builder runs a tiny version of grep(1) that was not built with PCRE. As such, grep