Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-26 Thread Junio C Hamano
Lars Schneider writes: > The difference between Travis and my machine is that I changed the > default shell to ZSH with a few plugins [1]. If I run the test with > plain BASH on my Mac then I can reproduce the test failure. Therefore, > we might want to adjust the commit message if anyone else

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-26 Thread Jeff King
On Thu, Jan 26, 2017 at 10:48:30AM +0100, Lars Schneider wrote: > Oh. I must have made a mistake on my very first test run. I can reproduce > the failure with ZSH and my plugins... looks like it's a Mac OS problem > and no TravisCI only problem after all. Thanks for digging into it. If it's reall

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-26 Thread Lars Schneider
> On 26 Jan 2017, at 10:14, Lars Schneider wrote: > > >> On 25 Jan 2017, at 23:51, Junio C Hamano wrote: >> >> Jeff King writes: >> >>> I guess the way to dig would be to add a test that looks at the output >>> of "type mv" or something, push it to a Travis-hooked branch, and then >>> wait

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-26 Thread Lars Schneider
> On 25 Jan 2017, at 23:51, Junio C Hamano wrote: > > Jeff King writes: > >> I guess the way to dig would be to add a test that looks at the output >> of "type mv" or something, push it to a Travis-hooked branch, and then >> wait for the output > > Sounds tempting ;-) Well, I tried that: mv

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Junio C Hamano
Jeff King writes: > I guess the way to dig would be to add a test that looks at the output > of "type mv" or something, push it to a Travis-hooked branch, and then > wait for the output Sounds tempting ;-)

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Jan 23, 2017 at 4:18 PM, Junio C Hamano wrote: >> >> * sb/unpack-trees-super-prefix (2017-01-12) 5 commits >> - SQUASH >> - unpack-trees: support super-prefix option >> - t1001: modernize style >> - t1000: modernize style >> - read-tree: use OPT_BOOL instead

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 10:16:40AM -0800, Junio C Hamano wrote: > > But whatever the cause, I think the workaround I posted is > > easy enough to do. > > Or spelling it explicitly as "/bin/mv" (forgetting systems that does > not have it in /bin but as /usr/bin/mv) would also defeat alias if > tha

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Stefan Beller
On Mon, Jan 23, 2017 at 4:18 PM, Junio C Hamano wrote: > > * sb/unpack-trees-super-prefix (2017-01-12) 5 commits > - SQUASH > - unpack-trees: support super-prefix option > - t1001: modernize style > - t1000: modernize style > - read-tree: use OPT_BOOL instead of OPT_SET_INT > > "git read-tre

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 25, 2017 at 06:01:11PM +0100, Johannes Schindelin wrote: > >> > Looks like "mv" prompts and then fails to move the file (so we get the >> > dangling blob for the source blob, and fsck doesn't report failure >> > because we didn't actually corrupt the destination bl

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 06:01:11PM +0100, Johannes Schindelin wrote: > > Looks like "mv" prompts and then fails to move the file (so we get the > > dangling blob for the source blob, and fsck doesn't report failure > > because we didn't actually corrupt the destination blob). > > IIRC I had simil

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-25 Thread Johannes Schindelin
Hi Peff, On Tue, 24 Jan 2017, Jeff King wrote: > On Tue, Jan 24, 2017 at 11:04:21AM +0100, Lars Schneider wrote: > > > "fsck: prepare dummy objects for --connectivity-check" seems to > > make t1450-fsck.sh fail on macOS with TravisCI: > > > > Initialized empty Git repository in /Users/travis/bui

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-24 Thread Lars Schneider
> On 24 Jan 2017, at 14:27, Jeff King wrote: > > On Tue, Jan 24, 2017 at 11:04:21AM +0100, Lars Schneider wrote: > >> "fsck: prepare dummy objects for --connectivity-check" seems to >> make t1450-fsck.sh fail on macOS with TravisCI: >> >> Initialized empty Git repository in /Users/travis/build

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-24 Thread Jeff King
On Tue, Jan 24, 2017 at 11:04:21AM +0100, Lars Schneider wrote: > "fsck: prepare dummy objects for --connectivity-check" seems to > make t1450-fsck.sh fail on macOS with TravisCI: > > Initialized empty Git repository in /Users/travis/build/git/git/t/trash > directory.t1450-fsck/connectivity-only

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-24 Thread Lars Schneider
> On 24 Jan 2017, at 01:18, Junio C Hamano wrote: > > * jk/fsck-connectivity-check-fix (2017-01-17) 6 commits > (merged to 'next' on 2017-01-23 at e8e9b76b84) > + fsck: check HAS_OBJ more consistently > + fsck: do not fallback "git fsck " to "git fsck" > + fsck: tighten error-checks of "git fsc

What's cooking in git.git (Jan 2017, #04; Mon, 23)

2017-01-23 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. You can find the changes described