Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-11-14 Thread Karsten Blees
Am 29.10.2013 10:09, schrieb Karsten Blees: On Mon, Oct 28, 2013 at 10:04 PM, Vicent Martí tan...@gmail.com wrote: On Mon, Oct 28, 2013 at 8:45 PM, Karsten Blees karsten.bl...@gmail.com wrote: Regarding performance, khash uses open addressing, which requires more key comparisons

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-29 Thread Karsten Blees
On Mon, Oct 28, 2013 at 10:04 PM, Vicent Martí tan...@gmail.com wrote: On Mon, Oct 28, 2013 at 8:45 PM, Karsten Blees karsten.bl...@gmail.com wrote: Regarding performance, khash uses open addressing, which requires more key comparisons (O(1/(1-load_factor))) than chaining

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-28 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Sat, Oct 26, 2013 at 6:23 AM, Junio C Hamano gits...@pobox.com wrote: * kb/fast-hashmap (2013-10-22) 12 commits - remove old hash.[ch] implementation - read-cache.c: fix memory leaks caused by removed cache entries - name-hash.c: remove cache

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-28 Thread Vicent Martí
On Mon, Oct 28, 2013 at 4:48 PM, Junio C Hamano gits...@pobox.com wrote: jk/pack-bitmap adds khash.h, which from a first glance looks like yet another hash table implementation. I was just wondering if kb's new hash tables can cover the need of pack-bitmap.c too so we can remove khash.h

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-28 Thread Junio C Hamano
Vicent Martí tan...@gmail.com writes: On Mon, Oct 28, 2013 at 4:48 PM, Junio C Hamano gits...@pobox.com wrote: jk/pack-bitmap adds khash.h, which from a first glance looks like yet another hash table implementation. I was just wondering if kb's new hash tables can cover the need of

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-28 Thread Karsten Blees
Am 28.10.2013 17:16, schrieb Vicent Martí: On Mon, Oct 28, 2013 at 4:48 PM, Junio C Hamano gits...@pobox.com wrote: jk/pack-bitmap adds khash.h, which from a first glance looks like yet another hash table implementation. I was just wondering if kb's new hash tables can cover the need of

Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-28 Thread Vicent Martí
On Mon, Oct 28, 2013 at 8:45 PM, Karsten Blees karsten.bl...@gmail.com wrote: The new `hashmap.c` covers the first case quite well (albeit slightly more verbosely than I'd like), but in the second case it doesn't quite work. Since the new hash needs to embed the struct hashmap_entry on all its

What's cooking in git.git (Oct 2013, #06; Fri, 25)

2013-10-25 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. You can find the changes described here in the integration branches of the repositories listed at