Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Junio C Hamano
Jeff King writes: > On Tue, Oct 10, 2017 at 12:03:14PM -0700, Jonathan Nieder wrote: > >> Where I worry is about commands where the line between porcelain and >> plumbing blur, like "git log --format=raw". I actually still prefer >> the approach where "color.ui=always" becomes

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Jeff King
On Tue, Oct 10, 2017 at 12:03:14PM -0700, Jonathan Nieder wrote: > > I do wonder if people would end up seeing some corner cases as > > regressions, though. Right now "diff-tree" _does_ color the output by > > default, and it would stop doing so under your scheme. That's the right > > thing to do

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Tue, Oct 10, 2017 at 09:51:38PM +0900, Junio C Hamano wrote: >> I think the right fix to the original problem (you cannot remove >> auto-color from the plumbing) is to stop paying attention to color >> configuration from the default config. I wonder if something like

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Jeff King
On Tue, Oct 10, 2017 at 09:51:38PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > :( I was worried that this might hit some third-party scripts. > > ... > > All that said, should we revisit the decision from 6be4595edb? The two > > code changes we could make are: > > > >

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Junio C Hamano
Jeff King writes: > :( I was worried that this might hit some third-party scripts. > ... > All that said, should we revisit the decision from 6be4595edb? The two > code changes we could make are: > > 1. Adding a "--color" option to "git status". Commit 0c88bf5050 > (provide

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-10 Thread Jeff King
On Tue, Oct 10, 2017 at 12:42:43PM +0800, Nazri Ramliy wrote: > > commit 6be4595edb8e5b616c6e8b9fbc78b0f831fa2a87 > > Author: Jeff King > > Date: Tue Oct 3 09:46:06 2017 -0400 > > > > color: make "always" the same as "auto" in config > > > >

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-09 Thread Nazri Ramliy
> commit 6be4595edb8e5b616c6e8b9fbc78b0f831fa2a87 > Author: Jeff King > Date: Tue Oct 3 09:46:06 2017 -0400 > > color: make "always" the same as "auto" in config > > Would you like to take a stab at adding it? builtin/commit.c and >

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-09 Thread Jonathan Nieder
Nazri Ramliy wrote: > On Tue, Oct 10, 2017 at 8:16 AM, Jonathan Nieder wrote: >> Nazri Ramliy wrote: >>> I used to work before, but now: >>> >>> $ git version >>> git version 2.15.0.rc0.39.g2f0e14e649 >>> >>> $ git status --color=always >>> error: unknown option

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-09 Thread Nazri Ramliy
On Tue, Oct 10, 2017 at 8:16 AM, Jonathan Nieder wrote: > Hi, > > Nazri Ramliy wrote: > >> I used to work before, but now: >> >> $ git version >> git version 2.15.0.rc0.39.g2f0e14e649 >> >> $ git status --color=always >> error: unknown option `color=always' >> usage: git

Re: What happened to "git status --color=(always|auto|never)"?

2017-10-09 Thread Jonathan Nieder
Hi, Nazri Ramliy wrote: > I used to work before, but now: > > $ git version > git version 2.15.0.rc0.39.g2f0e14e649 > > $ git status --color=always > error: unknown option `color=always' > usage: git status [] [--] ... Which version did it work in? That would allow me to bisect. Thanks,

What happened to "git status --color=(always|auto|never)"?

2017-10-09 Thread Nazri Ramliy
I used to work before, but now: $ git version git version 2.15.0.rc0.39.g2f0e14e649 $ git status --color=always error: unknown option `color=always' usage: git status [] [--] ... Is it no longer supported? nazri