Re: git-prompt.sh incompatible with non-basic global grep.patternType

Eric Sunshine writes: >> Later when the grep API was used in revision graversal machinery, > > s/graversal/traversal/ Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: git-prompt.sh incompatible with non-basic global grep.patternType

On Fri, Jul 22, 2016 at 3:21 PM, Junio C Hamano wrote: > Subject: [PATCH] grep: further simplify setting the pattern type > > When c5c31d33 (grep: move pattern-type bits support to top-level > grep.[ch], 2012-10-03) introduced grep_commit_pattern_type() helper > function, the

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Jeff King writes: > But even that is a lesser breakage than taking away grep.extendedRegexp > entirely. Taking it away breaks anybody who uses it; tweaking (2) only > breaks people who set both config variables. But why would anyone do > that? OK. Now we have an evidence that we

Re: git-prompt.sh incompatible with non-basic global grep.patternType

On Fri, Jul 22, 2016 at 12:51:00PM -0700, Junio C Hamano wrote: > Jeff King writes: > > >> This comes from b22520a3 (grep: allow -E and -n to be turned on by > >> default via configuration, 2011-03-30) back when we didn't have a > >> more generic grep.patternType configuration

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Jeff King writes: >> This comes from b22520a3 (grep: allow -E and -n to be turned on by >> default via configuration, 2011-03-30) back when we didn't have a >> more generic grep.patternType configuration mechanism in v1.7.5 >> days, and it probably need to be deprecated to

Re: git-prompt.sh incompatible with non-basic global grep.patternType

On Fri, Jul 22, 2016 at 12:21:31PM -0700, Junio C Hamano wrote: > One thing that I noticed is that there is this strange field > in grep_opt called .extended_regexp_option; it only is set from the > boolean configuration grep.extendedregexp and worse yet it takes > precedence over the command

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Jeff King writes: > I gave a very cursory look when I wrote the other email, and your > alternative solution is what looked like the most elegant fix to me. > > I suspect this bug has been there quite a while, so no rush. :) Here is what I am going to queue. One thing that I

Re: git-prompt.sh incompatible with non-basic global grep.patternType

On Wed, Jul 20, 2016 at 01:10:42PM -0700, Junio C Hamano wrote: > This may fix it. I think the root cause is that logic to smear > "pattern type" into various broken-down fields in grep_opt for the > short-hands like --basic-regexp option needs to leave "I am setting > this short-hand" mark to

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Jeff King writes: > On Mon, Jul 18, 2016 at 03:56:09PM -0700, Richard Soderberg wrote: > >> ps. git log --basic-regexp does not fix the issue, as for unknown >> reasons (I'll start another thread) the command-line option doesn't >> override grep.patternType. > > Dscho gave a fix

Re: git-prompt.sh incompatible with non-basic global grep.patternType

On Mon, Jul 18, 2016 at 03:56:09PM -0700, Richard Soderberg wrote: > ps. git log --basic-regexp does not fix the issue, as for unknown > reasons (I'll start another thread) the command-line option doesn't > override grep.patternType. Dscho gave a fix for your immediate issue, but this "ps"

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Hi Richard, On Tue, 19 Jul 2016, Richard Soderberg wrote: > Aha! Yes, this works precisely as intended: the prompt works > correctly, and quickly, with this change in place. Okay, next step for you: read http://github.com/git-for-windows/git/blob/master/Documentation/SubmittingPatches and

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Aha! Yes, this works precisely as intended: the prompt works correctly, and quickly, with this change in place. - R. On Tue, Jul 19, 2016 at 4:24 AM, Johannes Schindelin wrote: > Hi Richard, > > On Mon, 18 Jul 2016, Richard Soderberg wrote: > >> Hi, I wanted to

Re: git-prompt.sh incompatible with non-basic global grep.patternType

Hi Richard, On Mon, 18 Jul 2016, Richard Soderberg wrote: > Hi, I wanted to report something interesting that I found while tracing > a severe slowdown in git-prompt.sh. > > https://github.com/git/git/commit/6d158cba282f22fa1548af1188f78042fed30aed#diff-f37c4f4a898819f0ca4b5ff69e81d4d9R141 > >

git-prompt.sh incompatible with non-basic global grep.patternType

Hi, I wanted to report something interesting that I found while tracing a severe slowdown in git-prompt.sh. https://github.com/git/git/commit/6d158cba282f22fa1548af1188f78042fed30aed#diff-f37c4f4a898819f0ca4b5ff69e81d4d9R141 Way back in this commit, someone added a useful chunk of code that