Jeremy Huddleston Sequoia writes:
>> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
>> index 924a266126..53c0cb6dea 100755
>> --- a/t/t3700-add.sh
>> +++ b/t/t3700-add.sh
>> @@ -350,6 +350,7 @@ test_expect_success POSIXPERM,SYMLINKS 'git add
>> --chmod=+x with symlinks' '
>> '
>>
>> test_expect_s
> On Oct 10, 2016, at 10:41, Junio C Hamano wrote:
>
> Jeremy Huddleston Sequoia writes:
>
>> Actually, looks like that as just a rabbit hole. The real issue
>> looks to be because an earlier test drops down xfoo3 as a symlink,
>> which causes this test to fail due to the collision. I'll get
Am 10.10.2016 um 19:41 schrieb Junio C Hamano:
I also notice that the problematic test uses "chmod 755"; don't we
need POSIXPERM prerequisite on this test, too, I wonder?
Good point. Without POSIXPERM the test demonstrate that, since chmod 755
is basically a noop, the following add --chmod=-x
Junio C Hamano writes:
> ...
> I also notice that the problematic test uses "chmod 755"; don't we
> need POSIXPERM prerequisite on this test, too, I wonder?
>
> Thanks.
>
> -- >8 --
> t3700: fix broken test under !SANITY
>
> An "add --chmod=+x" test recently added by 610d55af0f ("add: modify
> al
Jeremy Huddleston Sequoia writes:
> Actually, looks like that as just a rabbit hole. The real issue
> looks to be because an earlier test drops down xfoo3 as a symlink,
> which causes this test to fail due to the collision. I'll get out
> a patch in a bit.
[administrivia: please don't top-post
> On Oct 9, 2016, at 20:22, Jeremy Huddleston Sequoia
> wrote:
>
> The issue is that the whitespace before the filename in $(git ls-files -s
> "$2") is a tab, and test_mode_in_index only looks for a space.
Actually, looks like that as just a rabbit hole. The real issue looks to be
because a
The issue is that the whitespace before the filename in $(git ls-files -s "$2")
is a tab, and test_mode_in_index only looks for a space.
><
> On Oct 9, 2016, at 19:51, Jeremy Huddleston Sequoia
> wrote:
>
>
>> On Oct 9, 2016, at 17:15, Jeremy Huddleston Sequoia
>> wrote:
>>
>> Hi Thomas,
> On Oct 9, 2016, at 17:15, Jeremy Huddleston Sequoia
> wrote:
>
> Hi Thomas,
>
> I wanted to let you know that this patch of yours, which landed in git
> 2.10.1, introduced some test failures, seen on macOS.
>
> Let me know if you need any additional information to track these down.
>
> Th
Hi Thomas,
I wanted to let you know that this patch of yours, which landed in git 2.10.1,
introduced some test failures, seen on macOS.
Let me know if you need any additional information to track these down.
Thanks,
Jeremy
not ok 40 - git add --chmod=[+-]x changes index with already added file
9 matches
Mail list logo