Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-06 Thread Junio C Hamano
Jeff King p...@peff.net writes: Yeah, I didn't consider the mode impact of using mkstemp. That is definitely a regression that should be fixed. Though of course if you really do want 0644, you should set your umask to 0022. :) ... If you haven't set core.sharedrepository, then

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-06 Thread Paul Sokolovsky
Hello, On Mon, 5 Jan 2015 22:47:02 -0500 Jeff King p...@peff.net wrote: On Mon, Jan 05, 2015 at 09:07:24PM +0200, Paul Sokolovsky wrote: So, after the upgrade, users started to report that accessing info/refs file of a repo, as required for HTTP dump protocol, leads to 403 Forbidden

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-06 Thread Paul Sokolovsky
Hello, On Tue, 06 Jan 2015 02:08:16 -0800 Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: Yeah, I didn't consider the mode impact of using mkstemp. That is definitely a regression that should be fixed. Though of course if you really do want 0644, you should set

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-06 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Jeff King p...@peff.net writes: Yeah, I didn't consider the mode impact of using mkstemp. That is definitely a regression that should be fixed. Though of course if you really do want 0644, you should set your umask to 0022. :) ... If you haven't set

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-06 Thread Jeff King
On Tue, Jan 06, 2015 at 02:08:16AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: Yeah, I didn't consider the mode impact of using mkstemp. That is definitely a regression that should be fixed. Though of course if you really do want 0644, you should set your umask to 0022.

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-05 Thread Torsten Bögershausen
On 2015-01-05 20.07, Paul Sokolovsky wrote: Hello, We recently upgraded to git 2.2.1 from 2.1.x and faced issue with accessing repositories over dump HTTP protocol. In our setting, repositories are managed by Gerrit, so owned by Gerrit daemon user, but we also offer anon access via smart

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-05 Thread Jeff King
On Mon, Jan 05, 2015 at 09:07:24PM +0200, Paul Sokolovsky wrote: So, after the upgrade, users started to report that accessing info/refs file of a repo, as required for HTTP dump protocol, leads to 403 Forbidden HTTP error. We traced that to 0600 filesystem permissions for such files (for

git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-05 Thread Paul Sokolovsky
Hello, We recently upgraded to git 2.2.1 from 2.1.x and faced issue with accessing repositories over dump HTTP protocol. In our setting, repositories are managed by Gerrit, so owned by Gerrit daemon user, but we also offer anon access via smart and dumb HTTP protocols. For the latter, we of