Re: git fsck exit code?

2014-09-09 Thread Jeff King
On Mon, Sep 01, 2014 at 02:17:43PM -0400, David Turner wrote: > > I don't think git fsck should return !0 in this case. Yes, it's an > > inconsistency in the repo, but it's sometimes due to erroneous > > conversions from another SCM or some other (non-standard) implementation > > of the git client

Re: git fsck exit code?

2014-09-01 Thread David Turner
On Sun, 2014-08-31 at 20:54 +0200, Øyvind A. Holm wrote: > On 29 August 2014 22:18, David Turner wrote: > > On Fri, 2014-08-29 at 12:21 -0700, Junio C Hamano wrote: > > > Jeff King writes: > > > > On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > > > > > It looks like git fsck exits

Re: git fsck exit code?

2014-09-01 Thread Øyvind A . Holm
On 31 August 2014 20:54, Øyvind A. Holm wrote: > On 29 August 2014 22:18, David Turner wrote: > > error in tree 9f50addba2b4e9e928d9c6a7056bdf71b36fba90: contains > > duplicate file entries > > I don't think git fsck should return !0 in this case. Yes, it's an > inconsistency in the repo, but it's

Re: git fsck exit code?

2014-08-31 Thread Øyvind A . Holm
On 29 August 2014 22:18, David Turner wrote: > On Fri, 2014-08-29 at 12:21 -0700, Junio C Hamano wrote: > > Jeff King writes: > > > On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > > > > It looks like git fsck exits with 0 status even if there are > > > > some errors. The only case

Re: git fsck exit code?

2014-08-29 Thread Junio C Hamano
Jeff King writes: > On Fri, Aug 29, 2014 at 04:18:00PM -0400, David Turner wrote: > >> > Even if git does not die, whenever it says broken link, missing >> > object, or object corrupt, we set errors_found and that variable >> > affects the exit status of fsck. What does "some errors" exactly >>

Re: git fsck exit code?

2014-08-29 Thread Jeff King
On Fri, Aug 29, 2014 at 04:18:00PM -0400, David Turner wrote: > > Even if git does not die, whenever it says broken link, missing > > object, or object corrupt, we set errors_found and that variable > > affects the exit status of fsck. What does "some errors" exactly > > mean in the original repo

Re: git fsck exit code?

2014-08-29 Thread David Turner
On Fri, 2014-08-29 at 12:21 -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > > > >> It looks like git fsck exits with 0 status even if there are some > >> errors. The only case where there's a non-zero exit code is if > >> veri

Re: git fsck exit code?

2014-08-29 Thread Junio C Hamano
Jeff King writes: > On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > >> It looks like git fsck exits with 0 status even if there are some >> errors. The only case where there's a non-zero exit code is if >> verify_pack reports errors -- but not e.g. fsck_object_dir. > > It will als

Re: git fsck exit code?

2014-08-29 Thread Jeff King
On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > It looks like git fsck exits with 0 status even if there are some > errors. The only case where there's a non-zero exit code is if > verify_pack reports errors -- but not e.g. fsck_object_dir. It will also bail non-zero with _certain

git fsck exit code?

2014-08-27 Thread David Turner
It looks like git fsck exits with 0 status even if there are some errors. The only case where there's a non-zero exit code is if verify_pack reports errors -- but not e.g. fsck_object_dir. Is that really the intended behavior? I think it would be nice to at least support --exit-code (but probably