Re: git https transport and wrong password

2013-04-03 Thread Mikko Rapeli
Maybe my git installation was incomplete before when running from ~/bin since I was not able to set break points to http_request() and some debug code was not there until I ran git through bin-wrappers in the source tree. I added some debug prints to http.c functions http_request() and

Re: git https transport and wrong password

2013-04-03 Thread Jeff King
[+cc Daniel for curl questions below] On Wed, Apr 03, 2013 at 12:43:02PM +0300, Mikko Rapeli wrote: Maybe my git installation was incomplete before when running from ~/bin since I was not able to set break points to http_request() and some debug code was not there until I ran git through

Re: git https transport and wrong password

2013-04-03 Thread Mikko Rapeli
On Wed, Apr 03, 2013 at 10:12:12AM -0400, Jeff King wrote: I would expect without the username in the URL for it to make only two requests: one to get the first 401, then git collects the credentials, then a follow-up with the credentials. But instead we get: $ GIT_CURL_VERBOSE=1 git

git https transport and wrong password

2013-04-02 Thread Mikko Rapeli
Hi, I have a problem with git (1.7.9 and 1.8.2.357.gcc3e4eb) and https transport to gerrit server (2.5.1-3-g719dfc7). I'm producing the problem on Cygwin but my colleagues have same issue on Linux as well. Gerrit server is matching corporate policies with single sign on, so after three failed

Re: git https transport and wrong password

2013-04-02 Thread Mikko Rapeli
On Tue, Apr 02, 2013 at 06:54:40PM +0300, Mikko Rapeli wrote: I have client side logs with GIT_CURL_VERBOSE=1 but from intranet so can't publish them directly. Here's roughly what the log shows: Maybe this is simpler summary: $ grep HTTP\/1.1 log.txt GET ...info/refs?service=git-upload-pack

Re: git https transport and wrong password

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 06:54:40PM +0300, Mikko Rapeli wrote: I have a problem with git (1.7.9 and 1.8.2.357.gcc3e4eb) and https transport to gerrit server (2.5.1-3-g719dfc7). I'm producing the problem on Cygwin but my colleagues have same issue on Linux as well. Gerrit server is matching

Re: git https transport and wrong password

2013-04-02 Thread Mikko Rapeli
On Tue, Apr 02, 2013 at 03:28:45PM -0400, Jeff King wrote: We get redirected somewhere where we provide the (presumably wrong) credential again. I do not think that is git's fault; the server asked us to make the extra request. Is that part of the lockout procedure? If it is not, it seems odd

Re: git https transport and wrong password

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 10:47:51PM +0300, Mikko Rapeli wrote: Don't know anything about curl but maybe git could parse the url for a username and prompt for the password before the first 401 failure roundtrip that's now in place. I guess most of this logic is in http.c. We used to do that but

Re: git https transport and wrong password

2013-04-02 Thread Mikko Rapeli
On Tue, Apr 02, 2013 at 04:05:51PM -0400, Jeff King wrote: On Tue, Apr 02, 2013 at 10:47:51PM +0300, Mikko Rapeli wrote: Don't know anything about curl but maybe git could parse the url for a username and prompt for the password before the first 401 failure roundtrip that's now in place.