On Tue, Apr 16, 2013 at 10:26:40PM -0700, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
René Scharfe rene.scha...@lsrfire.ath.cx writes:
How about making split_ident_line() a bit friendlier be letting it
provide the epoch as default time stamp instead of NULL?
On Wed, Apr 17, 2013 at 09:22:01AM +0400, Ivan Lyapunov wrote:
I checked René Scharfe's patch and it works - no more git log crash.
Also I checked a broken commits by git show and the most of them
created by me. I can confirm I never used anyting else except console
git commit or netbeans gui
netbeans use some integrated git wrapper and I don't know about JGit
source base or not. In Eclipse we use Egit. Also all broken commits
limited to november 2012, but we still continue to use the same
development environments without any problems
Ivan
2013/4/17 John Keeping j...@keeping.me.uk:
On Wed, 17 Apr 2013 13:14:48 +0400
Ivan Lyapunov dron...@gmail.com wrote:
netbeans use some integrated git wrapper and I don't know about JGit
source base or not. In Eclipse we use Egit. Also all broken commits
limited to november 2012, but we still continue to use the same
development
missed a list sorry for dup
I ment the same because git changes the version too. Also
netbeans/eclipse upgrade are not synced, because of different
products. So the same ment only names, not versions. But in deep
search another repos I found the broken commits in Eclipse repo dated
by 13 march
Jeff King p...@peff.net writes:
What about sane_ident_split in builtin/commit.c? It explicitly rejects a
NULL date. The logic in determine_author_info is a little hard to follow
(it assembles the ident line with fmt_ident and then reparses it), but I
believe it should be catching a bogus line
Am 17.04.2013 08:39, schrieb Jeff King:
On Tue, Apr 16, 2013 at 10:26:40PM -0700, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
René Scharfe rene.scha...@lsrfire.ath.cx writes:
How about making split_ident_line() a bit friendlier be letting it
provide the epoch as default
On Wed, Apr 17, 2013 at 07:59:28PM +0200, René Scharfe wrote:
What about sane_ident_split in builtin/commit.c? It explicitly rejects a
NULL date. The logic in determine_author_info is a little hard to follow
(it assembles the ident line with fmt_ident and then reparses it), but I
believe it
Am 17.04.2013 20:02, schrieb Jeff King:
I think we also need to do something about git cat-file -p, which does
not use the split_ident_line parser (but has its own problems with the
home-grown parser).
Ah, while it prints commit object contents verbatim, it formats the date
of tags. And it
Am 16.04.2013 18:55, schrieb Ivan Lyapunov:
git version 1.8.2.1 crashes on my ArchLinux x86_64 on git log command
gdb bt is attached
git log | less
does not crash in same repo
I cannot share a repo for a debug purposes since it's private repo of
my employer
but I can perform any
René Scharfe rene.scha...@lsrfire.ath.cx writes:
Does this patch help?
pretty.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/pretty.c b/pretty.c
index d3a82d2..713eefc 100644
--- a/pretty.c
+++ b/pretty.c
@@ -405,8 +405,8 @@ void pp_user_info(const
First, lest I forget again: Thank you, Ivan, for the very useful
bug report!
Am 16.04.2013 21:45, schrieb Junio C Hamano:
René Scharfe rene.scha...@lsrfire.ath.cx writes:
Does this patch help?
pretty.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
On Tue, Apr 16, 2013 at 9:45 PM, Junio C Hamano gits...@pobox.com wrote:
It still is curious how a malformed line was created in the first
place. I wouldn't worry if a private tool used hash-object to
create such a commit, but if it is something that is commonly used
(e.g. git commit), others
On Tue, Apr 16, 2013 at 12:45:03PM -0700, Junio C Hamano wrote:
René Scharfe rene.scha...@lsrfire.ath.cx writes:
Does this patch help?
pretty.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/pretty.c b/pretty.c
index d3a82d2..713eefc 100644
---
René Scharfe rene.scha...@lsrfire.ath.cx writes:
How about making split_ident_line() a bit friendlier be letting it
provide the epoch as default time stamp instead of NULL?
Two knee-jerk concerns I have without going back to the callers:
* Would that 0 ever be given to the approxidate
Looks like I missed a lot of fun I'm sleeping ;)
The current repo is a product of our core crossplatform team, working
on Linux/MacOSX/Win32 environment. The Linux environment also
separates on Ubuntu/ArchLinux distros, and probably most of repo bugs
coming from ArchLinux, since other
I checked René Scharfe's patch and it works - no more git log crash.
Also I checked a broken commits by git show and the most of them
created by me. I can confirm I never used anyting else except console
git commit or netbeans gui to commit, which is just git gui wrapper
tool. Several commits is a
Junio C Hamano gits...@pobox.com writes:
René Scharfe rene.scha...@lsrfire.ath.cx writes:
How about making split_ident_line() a bit friendlier be letting it
provide the epoch as default time stamp instead of NULL?
Two knee-jerk concerns I have without going back to the callers:
* Would
18 matches
Mail list logo
