Re: git segfaults on older Solaris releases

2016-04-12 Thread Patrick Steinhardt
On Sat, Apr 09, 2016 at 01:39:05PM -0400, Jeff King wrote: > On Sat, Apr 09, 2016 at 09:02:38AM +0200, Tom G. Christensen wrote: > > > I've finished testing 2.8.1 and I found one more case where a null is being > > printed and causing a segfault. This happens even on Solaris 8 and 9. > > The

Re: git segfaults on older Solaris releases

2016-04-09 Thread Jeff King
On Sat, Apr 09, 2016 at 10:17:56PM +0200, Tom G. Christensen wrote: > On 09/04/16 19:39, Jeff King wrote: > > > [1/3]: config: lower-case first word of error strings > > [2/3]: git_config_set_multivar_in_file: all non-zero returns are errors > > [3/3]: git_config_set_multivar_in_file:

Re: git segfaults on older Solaris releases

2016-04-09 Thread Tom G. Christensen
On 09/04/16 19:39, Jeff King wrote: [1/3]: config: lower-case first word of error strings [2/3]: git_config_set_multivar_in_file: all non-zero returns are errors [3/3]: git_config_set_multivar_in_file: handle "unset" errors I applied them to 2.8.1 and ran the testsuite again on

Re: git segfaults on older Solaris releases

2016-04-09 Thread Jeff King
On Sat, Apr 09, 2016 at 09:02:38AM +0200, Tom G. Christensen wrote: > I've finished testing 2.8.1 and I found one more case where a null is being > printed and causing a segfault. This happens even on Solaris 8 and 9. > The failling test is t3200.63. Oh good, this one wasn't me. :) It's just a

Re: git segfaults on older Solaris releases

2016-04-09 Thread Tom G. Christensen
On 07/04/16 22:19, Tom G. Christensen wrote: On 07/04/16 20:50, Junio C Hamano wrote: Junio C Hamano writes: So perhaps this is all we need to fix your box. setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I applied this patch to 2.8.0 and have completed

Re: git segfaults on older Solaris releases

2016-04-07 Thread Jeff King
On Thu, Apr 07, 2016 at 12:37:53PM -0700, Junio C Hamano wrote: > -- >8 -- > Subject: setup.c: do not feed NULL to "%.*s" even with the precision 0 > > A recent update 75faa45a (replace trivial malloc + sprintf / strcpy > calls with xstrfmt, 2015-09-24) rewrote > > prepare an empty buffer

Re: git segfaults on older Solaris releases

2016-04-07 Thread Tom G. Christensen
On 07/04/16 20:50, Junio C Hamano wrote: Junio C Hamano writes: So perhaps this is all we need to fix your box. setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Yes that seems to work very well. I applied this patch to 2.8.0 and have completed a testsuite

Re: git segfaults on older Solaris releases

2016-04-07 Thread Junio C Hamano
Jeff King writes: >> So perhaps this is all we need to fix your box. >> >> setup.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/setup.c b/setup.c >> index 3439ec6..b6c8aab 100644 >> --- a/setup.c >> +++ b/setup.c >> @@ -103,7 +103,7 @@ char

Re: git segfaults on older Solaris releases

2016-04-07 Thread Jeff King
On Thu, Apr 07, 2016 at 11:50:46AM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > "Tom G. Christensen" writes: > > > >> The reason for the crash is simple, a null value was passed to the 's' > >> format for the *printf family of functions.

Re: git segfaults on older Solaris releases

2016-04-07 Thread Tom G. Christensen
On 07/04/16 20:32, Junio C Hamano wrote: "Tom G. Christensen" writes: The reason for the crash is simple, a null value was passed to the 's' format for the *printf family of functions. ... Passing a null value to the 's' format is explicitly documented as giving

Re: git segfaults on older Solaris releases

2016-04-07 Thread David Turner
On Thu, 2016-04-07 at 11:50 -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > "Tom G. Christensen" writes: > > > > > The reason for the crash is simple, a null value was passed to > > > the 's' > > > format for the *printf family of functions.

Re: git segfaults on older Solaris releases

2016-04-07 Thread Junio C Hamano
Junio C Hamano writes: > "Tom G. Christensen" writes: > >> The reason for the crash is simple, a null value was passed to the 's' >> format for the *printf family of functions. >> ... >> Passing a null value to the 's' format is explicitly documented as

Re: git segfaults on older Solaris releases

2016-04-07 Thread Junio C Hamano
"Tom G. Christensen" writes: > The reason for the crash is simple, a null value was passed to the 's' > format for the *printf family of functions. > ... > Passing a null value to the 's' format is explicitly documented as > giving undefined results on Solaris, even on

git segfaults on older Solaris releases

2016-04-07 Thread Tom G. Christensen
Hello, While working on an update to the git packages in tgcware(1) I ran into segfaults when running the testsuite. Here's what it looks like on Solaris 7/SPARC: Core was generated by `/export/home/tgc/buildpkg/git/src/git-upstream/git update-index should-be-empty'. Program terminated