Re: git submodule: update=!command

2015-03-18 Thread Chris Packham
On Wed, Mar 18, 2015 at 8:43 PM, Chris Packham wrote: > On Wed, Mar 18, 2015 at 10:05 AM, Junio C Hamano wrote: >> Ryan Lortie writes: >> >>> On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote: With more recent versions of Git, namely, the versions after 30a52c1d (Merge branch 'ms/su

Re: git submodule: update=!command

2015-03-18 Thread Chris Packham
On Wed, Mar 18, 2015 at 10:05 AM, Junio C Hamano wrote: > Ryan Lortie writes: > >> On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote: >>> With more recent versions of Git, namely, the versions after >>> 30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint, >>> 2015-03-13), the do

Re: git submodule: update=!command

2015-03-18 Thread Chris Packham
A little late to this thread On Wed, Mar 18, 2015 at 8:50 AM, Jeff King wrote: > On Tue, Mar 17, 2015 at 03:28:57PM -0400, Ryan Lortie wrote: > >> The first is a question about git's basic policy with respect to things >> like this. I hope that it's safe to assume that running 'git' commands >>

Re: git submodule: update=!command

2015-03-17 Thread Ryan Lortie
kara, On Tue, Mar 17, 2015, at 17:05, Junio C Hamano wrote: > If you check the output from > > git diff 30a52c1d^ 30a52c1d > > and find it appropriately address the problem you originally had, > that would be wonderful, and if you can suggest further improvement, > that is equally good. Ind

Re: git submodule: update=!command

2015-03-17 Thread Junio C Hamano
Ryan Lortie writes: > On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote: >> With more recent versions of Git, namely, the versions after >> 30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint, >> 2015-03-13), the documentation pages already have updated >> descriptions around th

Re: git submodule: update=!command

2015-03-17 Thread Ryan Lortie
On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote: > With more recent versions of Git, namely, the versions after > 30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint, > 2015-03-13), the documentation pages already have updated > descriptions around this area. sigh. That's what

Re: git submodule: update=!command

2015-03-17 Thread Junio C Hamano
Ryan Lortie writes: > 'man git-submodule' contains mention (in one place) that: > > Setting the key submodule.$name.update to !command > will cause command to be run. > > This is not documented in 'man gitmodules' (which documents the other > possible values for the 'update' key) Yes, th

Re: git submodule: update=!command

2015-03-17 Thread Ryan Lortie
On Tue, Mar 17, 2015, at 15:50, Jeff King wrote: > Yeah, spelling out the security model more explicitly would be good. Please see the attached patch. Cheers 0001-docs-clarify-command-submodule-update-policy.patch Description: Binary data

Re: git submodule: update=!command

2015-03-17 Thread Jeff King
On Tue, Mar 17, 2015 at 03:28:57PM -0400, Ryan Lortie wrote: > The first is a question about git's basic policy with respect to things > like this. I hope that it's safe to assume that running 'git' commands > on repositories downloaded from potentially-hostile places will never > result in the a

git submodule: update=!command

2015-03-17 Thread Ryan Lortie
karaj, 'man git-submodule' contains mention (in one place) that: Setting the key submodule.$name.update to !command will cause command to be run. This is not documented in 'man gitmodules' (which documents the other possible values for the 'update' key) nor in 'man git-config' which also